Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nautical Navigation Data #408

Closed
7 tasks done
alex-w opened this issue Sep 26, 2018 · 34 comments · Fixed by #2489
Closed
7 tasks done

Nautical Navigation Data #408

alex-w opened this issue Sep 26, 2018 · 34 comments · Fixed by #2489
Assignees
Labels
feature Entirely new feature
Milestone

Comments

@alex-w
Copy link
Member

alex-w commented Sep 26, 2018

Original report: https://bugs.launchpad.net/stellarium/+bug/1106745

This feature request from old bug tracker.

Object Data

  • Rise, Meridian Passage and Set times
  • GHA (Greenwich Hour Angle)
  • SHA (Sidereal Hour Angle)
  • LHA (Local Hour Angle)

Twilights (start & end times)

  • civil
  • nautical
  • astronomical

An additional proposal from the old bug tracker: indicate beginning and ending times of all twilights for the selected location in the sun data... also moon rise and set data.

@alex-w alex-w added wishlist Long-term ideas state: confirmed A developer can reproduce the issue state: in progress The problem is in process of solution... labels Sep 26, 2018
@gzotti gzotti added feature Entirely new feature and removed wishlist Long-term ideas labels Sep 27, 2018
@larawag
Copy link

larawag commented Oct 22, 2019

Since this project seems to be still open, I tried to upload a first proposal for some nautical data like GHA, SHA, LHA, and UTC.

I would very appreciate, if you could give me any hints to optimize the code before I add some additional lines for the other topics.

@alex-w
Copy link
Member Author

alex-w commented Oct 24, 2019

Seems UTC is not required here (plus user may switch time to UTC in any time).

The twilight data may be added as extra info for the Sun.

@larawag
Copy link

larawag commented Oct 24, 2019

Well, I would like to use stellarium to predict the azimuth and altitude of the navigational stars being visible during twilight. Then, I would like to compare the angles GHA and LHA with the values being listed in nautical almanacs. The angles in almanacs depend on UT1 and hence, the time measured on a boat are typically both zone time and UT1. As I expect that UT1 is not available in stellarium, I suggested to use instead UTC and show additionally zone time.

To make this comparison more comfortable, I thought to present all relevant nautical data simultaneously to the user.

Maybe the whole strategy can be added to the Astronomical Calculations Window?

@alex-w
Copy link
Member Author

alex-w commented Oct 24, 2019

Yes, it's possible - just add a new tab into AstroCalc (Navigation?) and put here calculation of all needed navigational data (include UT1 time).

@gzotti
Copy link
Member

gzotti commented Oct 24, 2019

Please don't mix a specialized navigational plugin for a small (but interested) user group and the main program. Instead, yes, please add UTC or canonical twilight times (0/-6/-12/-18) if you feel it's necessary to the Infostring Navigational Extras. Or make a (small) separate Navigation GUI with that info that becomes visible when the Nav stars are activated. Can be the Nav settings GUI, just make it accessible more easily. Or really implement all the features suggested in #796 as well (including intermediate results for instruction/learning, and a chapter on navigation in the User Guide). I don't know if a separate UT1 is really needed, it diverges from UTC by less than 1 second.

@alex-w
Copy link
Member Author

alex-w commented Oct 24, 2019

Of course Nav Stars plugin may have one additional tab in main GUI or separate dialog for navigational computations - it’s OK for me. Maybe plugin should be renamed into Navigation and display nav. stars will be just one of many navigational tasks.

@gzotti
Copy link
Member

gzotti commented Oct 24, 2019

Yes, the Nav stars plugin can have the GUI for it. But not the main program's AstroCalc GUI!

@alex-w
Copy link
Member Author

alex-w commented Oct 24, 2019

Yes, this it perfect for me to use Nav Stars plugin for all navigational stuff.

@larawag
Copy link

larawag commented Oct 24, 2019

I fully agree to your discussion and I will try to make a suggestion for a piece of code to update the NavStar plugin.

So, the idea to add only a few lines of code becomes a small project. As being a hobbyist (like most of us?) I ask you for some time to do that.

@gzotti
Copy link
Member

gzotti commented Oct 24, 2019

Sure, take the time you require. Some issues have a long history :-) Most things are done by people who need some feature urgently themselves, because only these know particular inputs and outputs.

A-j-K added a commit to A-j-K/stellarium that referenced this issue Jan 5, 2020
@larawag
Copy link

larawag commented Jan 5, 2020

Hi, Andy, The attached picture shows parts of my current plugin extension as mentioned yesterday.

Thank you for sharing your files. Now we have the uncomfortable situation that we do have two different plugin drafts for the same task. Any suggestions how to proceed?

NavStar_Twilight

@A-j-K
Copy link
Contributor

A-j-K commented Jan 5, 2020

I already downloaded and compiled your code so I got a personal demonstration. Don't worry about two code repos. I'll halt what I'm doing on mine and we should proceed with yours, it's ahead of mine.

@A-j-K
Copy link
Contributor

A-j-K commented Jan 5, 2020

@larawag btw, I noticed that in your repo you have committed everything to the master branch. After reading the project Contrib guidelines I think we need to work in a branch and keep master clean so we can rebase (I see you haven't rebased since you forked). We need to fix these issues first.

@larawag
Copy link

larawag commented Jan 6, 2020

@A-j-K Ok, now the files are dropped in here. Currently it is still a framework since it is WIP.

You mentioned that you are going to write "educational packs" for students of Celestial Navigation. From my perspective, this seems to be a very big thing. Since CN is a navigation method that looks back on a long history, there are a lot of different methods to do CN. It feels hard to me, to decide which method would be the best for implementing here, so I started the coding with the following targets:

  • Enable the user to plan a trip (find the nav. stars for any location and the corresponding time in advance)
  • Help students to compare their own computation with the results shown in the main window and the final result of CN
  • Arouse curiosity about CN with this plugin

The sight reduction method I am going to use here is based on a least square approach. (So, it is not a semi-graphical method which might be a better choice for teaching purposes.)

@gzotti
Copy link
Member

gzotti commented Jan 6, 2020

If you are going into historical methods, a description of Tobias Mayer's Lunar method would be esp. interesting, as this is much less well known. But only after the sight reduction...

@A-j-K
Copy link
Contributor

A-j-K commented Jan 6, 2020

@larawag My plan regarding "education packs" was to discuss with instructors and those who teach CN in a classroom setting how Stellarium could be used to enhance the understanding of CN. I realize many already have a set method of tuition and instruction but getting an expectation of "user experience" would be useful. So, more to follow on that after I have done some homework.

But I also like @gzotti idea of being able to go deeper and look at the history too. Most classes in CN focus on the "modern" sight reduction techniques as that's all they need to know to pass an exam. But I like the idea of being able to dive deeper into subjects like this.

I'm just going to get your new branch and compile it up and then I'll get back to you.

@A-j-K
Copy link
Contributor

A-j-K commented Jan 6, 2020

@larawag Just a note, I ran in debug mode and on opening the config dialog got a runtime exception:-
NavStars.cpp line 112: Run-Time Check Failure #3 - The variable 'dayOfWeek' is being used without being initialized.

@A-j-K
Copy link
Contributor

A-j-K commented Jan 13, 2020

@larawag I've run into another issue, this one is somewhat more problematic and is concerned with the GHA (vernal equinox) ♈︎as displayed by ::addToExtraInfoString() function.

Steps to reproduce:-

  1. Start your version of Stellarium.
  2. Freeze the clock and do not allow Stellarium to go into real-time mode.
  3. Set location 56d 26m 00s North and 3d 47m 15s West, 3m (this may not matter but I have this set)
  4. Set the time to UTC 2020-01-13T07:12:34 (again, this may not matter but this is my setup)
  5. Select Vega and note GHAa (I see 221d 36.8m)
  6. Select Dubhe and note GHAa (I see 220d 23.2m)

With the Stellarium clock frozen I would not expect GHAa to move like this. My Almanac reduces to 220d 23.4m for this UTC time which appears ok for Dubhe but not Vega. Oddly, you can select objects all over and the split between these two GHAa values appears to be objects east of the local meridian or west.

@larawag
Copy link

larawag commented Jan 14, 2020

@A-j-K Thank you for your hint.

It seems to be more difficult since this unexpected behavior, i.e. the jump of the GHA value, happens at the meridian (what you reported) and - surprisingly - the jump is not restored 180° shifted to the meridian but its reset takes place at the autumnal equinox. I will take deeper look into this issue next weekend.

@larawag
Copy link

larawag commented Jan 16, 2020

@A-j-K
I could resolved this issue by modifying lines 227-230 in NavStars.cpp. Now you can find the current version in https://github.com/larawag/stellarium/tree/issue408_navStars

I appreciate your attentive investigation of the plugin extension very much. - Thank you.

@A-j-K
Copy link
Contributor

A-j-K commented Jan 16, 2020

@larawag Thanks, I will have a look this evening when I get home from work. On a side note, I've managed to speak with folk who provide instruction on CN as part of overall marine navigation and have some feedback on how this may direct the UI experience. Again, I'll leave feedback this evening, I'm at work right now so can't do more than leave this reply :)

@alex-w alex-w modified the milestones: 0.20.0, 0.20.1 Mar 29, 2020
@alex-w alex-w modified the milestones: 0.20.1, 0.20.2 Apr 20, 2020
@alex-w
Copy link
Member Author

alex-w commented Jun 8, 2020

@A-j-K any news?

@alex-w alex-w modified the milestones: 0.20.2, 0.20.3 Jun 22, 2020
@alex-w alex-w modified the milestones: 0.20.3, 0.20.4 Sep 17, 2020
@alex-w alex-w added this to To do in Navigation via automation Sep 30, 2020
@alex-w alex-w moved this from To do to In progress in Navigation Sep 30, 2020
@alex-w alex-w removed this from the 0.20.4 milestone Nov 13, 2020
@alex-w alex-w removed the state: confirmed A developer can reproduce the issue label Nov 19, 2020
@alex-w alex-w added this to To do in Didactic via automation Mar 8, 2021
@alex-w alex-w moved this from To do to In progress in Didactic May 10, 2021
@alex-w alex-w self-assigned this Jun 10, 2022
@alex-w
Copy link
Member Author

alex-w commented Jun 12, 2022

v0.21.3:

  • Twilight data

Twilight data was added for the Sun in version 0.21.3 (civil twilight by default)

@alex-w alex-w added this to the 0.22.2 milestone Jun 15, 2022
@alex-w
Copy link
Member Author

alex-w commented Jun 16, 2022

v0.22.2:

Twilights (start & end times)

  • civil
  • nautical
  • astronomical

Navigation automation moved this from In progress to Done Jun 25, 2022
Didactic automation moved this from In progress to Done Jun 25, 2022
@alex-w alex-w added state: fixed The bug has been fixed and removed state: in progress The problem is in process of solution... labels Jun 26, 2022
@github-actions
Copy link

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@alex-w alex-w added this to Needs triage in InfoBox via automation Jun 16, 2023
@alex-w alex-w moved this from Needs triage to Done in InfoBox Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment