Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic eye adaptation and objects outside the view #473

Open
alex-w opened this issue Sep 26, 2018 · 3 comments
Open

Dynamic eye adaptation and objects outside the view #473

alex-w opened this issue Sep 26, 2018 · 3 comments
Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash

Comments

@alex-w
Copy link
Member

alex-w commented Sep 26, 2018

Original report: https://bugs.launchpad.net/stellarium/+bug/967328

At a POV of 66° the moon above the horizon will reduce the apparent brightness of stars and all other objects, reproducing the effect of the moonlight in the reality. But when moving the line of vision so that the moon would be outside the window, this effect will disappear. So the brightness would increase, altough the moon in fact is above the horizon, of course (but only outside the window).

I guess, that is not the desired behaviour of the moonlight-effect, isn't it?

@alex-w alex-w added bug Something likely wrong in the code opinion OP thinks something should behave differently labels Sep 26, 2018
@gzotti gzotti removed the bug Something likely wrong in the code label Sep 26, 2018
@gzotti
Copy link
Member

gzotti commented Sep 26, 2018

It seems this is very much the intended behaviour. Probably it would make sense to add a special case for the Moon which globally brightens the sky even when it is outside the field of view.

@gzotti gzotti added the enhancement Improve existing functionality label Sep 26, 2018
@axd1967
Copy link
Contributor

axd1967 commented Nov 25, 2019

Maybe related to #351 (moonlight)?

@gzotti
Copy link
Member

gzotti commented Nov 25, 2019

Of course. But if you use a narrow FoV e.g. using binoculars or even an empty cardboard tube, or standing in the shadow of a building, you will also see a bit more in real life when the moon does not shine into your eyes. To sum it up:

  • A bright moon causes global sky brightening even if not directly visible.
  • A bright moon or other object inside the field of view strongly affects dynamic eye adaptation, simulating the direct effect of glare.

@alex-w alex-w added importance: low Small problem, rarely visible, no crash and removed opinion OP thinks something should behave differently labels Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash
Development

No branches or pull requests

3 participants