Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfoString fixes #2038

Merged
merged 3 commits into from
Nov 14, 2021
Merged

InfoString fixes #2038

merged 3 commits into from
Nov 14, 2021

Conversation

gzotti
Copy link
Member

@gzotti gzotti commented Nov 14, 2021

Description

Second part of the prematurely merged InfoString additions (#2037), i.e. bugfix for the checkbox and SUG additions.

Plus:

The beginning user may be overwhelmed by too much information. Also, some users with average screens will have info colliding with the left slide-out menu bar. This little branch introduces a default set of display options and lets the user find out more. The exact setting of defaults should be geared towards beginning users and may be subject to discussion before merge.

Fixes #2037, #1455

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 10 (irrelevant)
  • Graphics Card: irrelevant

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gzotti gzotti added enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash labels Nov 14, 2021
@gzotti gzotti added this to the 0.21.3 milestone Nov 14, 2021
@gzotti gzotti self-assigned this Nov 14, 2021
@gzotti gzotti added this to To do in GUI via automation Nov 14, 2021
@github-actions github-actions bot requested a review from alex-w November 14, 2021 10:55
@github-actions
Copy link

Hello @gzotti! Thank you for this enhancement.

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -702,7 +702,7 @@
<string>Display user customized information</string>
</property>
<property name="text">
<string>Customized</string>
<string comment="info group name">Customized</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@gzotti gzotti merged commit 3c623dd into master Nov 14, 2021
@gzotti gzotti deleted the info-fixes branch November 14, 2021 15:31
GUI automation moved this from To do to Done Nov 14, 2021
@alex-w alex-w added the state: fixed The bug has been fixed label Nov 14, 2021
@github-actions
Copy link

Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@Stellarium Stellarium locked as resolved and limited conversation to collaborators Nov 28, 2021
@alex-w alex-w removed the state: fixed The bug has been fixed label Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash
Projects
GUI
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants