Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Solar and Lunar info to InfoString (Fix #1455) #2037

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Add Solar and Lunar info to InfoString (Fix #1455) #2037

merged 1 commit into from
Nov 14, 2021

Conversation

gzotti
Copy link
Member

@gzotti gzotti commented Nov 13, 2021 •
edited
Loading

Description

Sometimes it is good to know horizontal coordinates of the Sun and Moon while observing other objects.
This branch adds yet another group with this information to the InfoString.

Maybe we should really start to deliver shortened object info by default. Info overlaps left menu.

Fixes #1455 (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 10 (irrelevant)
  • Graphics Card: (irrelevant)

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [!] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gzotti gzotti added enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash labels Nov 13, 2021
@gzotti gzotti added this to the 0.21.3 milestone Nov 13, 2021
@gzotti gzotti self-assigned this Nov 13, 2021
@github-actions github-actions bot requested a review from alex-w November 13, 2021 23:35
@github-actions
Copy link

Hello @gzotti! Thank you for this enhancement.

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

alex-w
alex-w approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w merged commit 65bc253 into master Nov 14, 2021
@alex-w alex-w deleted the solar-lunar-info branch November 14, 2021 01:49
@gzotti
Copy link
Member Author

gzotti commented Nov 14, 2021

Docs are still missing as indicated, and the checkbox does not fully work yet. :-( Please let me merge my own branches!

@gzotti gzotti mentioned this pull request Nov 14, 2021
Merged
12 tasks
gzotti added a commit that referenced this pull request Nov 14, 2021
@gzotti @alex-w
InfoString fixes (#2038)
3c623dd 
Completes #2037
* Missing translation code
* Add a "default" group to selected object info.
* Added context for info group names
* SUG updates

Co-authored-by: Alexander V. Wolf <alex.v.wolf@gmail.com>
@github-actions
Copy link

Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@Stellarium Stellarium locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alex-w alex-w alex-w approved these changes

Assignees

@gzotti gzotti

Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash
Milestone
0.21.3
Development

Successfully merging this pull request may close these issues.

sun position in the window 'sky option and visualization'
2 participants
@gzotti @alex-w