Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring mouse navigation #2089

Merged
merged 3 commits into from
Dec 12, 2021
Merged

Refactoring mouse navigation #2089

merged 3 commits into from
Dec 12, 2021

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Dec 8, 2021

Splitting the mouse navigation option into 2 options: navigation and zooming

Description

Splitting the mouse navigation option into 2 options adding the possibility to disable zooming by mouse without disabling the mouse dragging. As result we may disable zooming in the eyepiece mode in Oculars without disabling the dragging via mouse in same time.

Fixes #1317, #2086

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Tested on the MacBook Pro with trackpad

Test Configuration:

  • Operating system: macOS Monterey (12.0.1)

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

This commit adding the possibility to disable zooming by mouse without disabling the mouse dragging
@github-actions github-actions bot requested a review from gzotti December 8, 2021 09:55
@alex-w alex-w added this to To do in GUI via automation Dec 8, 2021
@alex-w alex-w linked an issue Dec 8, 2021 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files

@alex-w alex-w added the enhancement Improve existing functionality label Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Hello @alex-w! Thank you for this enhancement.

@alex-w
Copy link
Member Author

alex-w commented Dec 11, 2021

@gzotti I think this PR is ready to merge

@gzotti
Copy link
Member

gzotti commented Dec 11, 2021

Can you move in ocular view now? Or what has changed for the user?

Ah: I can move when no object is selected and centered. But when something is selected, I cannot move away using the mouse. Or yes, but I have to press the mouse button about 2 seconds until I can move the scene. This is also unexpected.

@alex-w
Copy link
Member Author

alex-w commented Dec 11, 2021

Can you move in ocular view now? Or what has changed for the user?

Ah: I can move when no object is selected and centered. But when something is selected, I cannot move away using the mouse. Or yes, but I have to press the mouse button about 2 seconds until I can move the scene. This is also unexpected.

The behaviour is connected to setting for eyepiece mode, but yes, you may disable zooming through mouse now separately

@gzotti
Copy link
Member

gzotti commented Dec 12, 2021

Well, I don't observe currently. You can merge if you want because working as before is possible, but I expect bug reports with my observations about this funny behaviour that it takes some weird move to finally drag the view in Oculars view.

@alex-w alex-w merged commit 6d68638 into master Dec 12, 2021
GUI automation moved this from To do to Done Dec 12, 2021
@alex-w alex-w deleted the refactoring/mouse-navigation branch December 12, 2021 04:43
@alex-w alex-w added this to the 0.21.3 milestone Dec 12, 2021
@alex-w alex-w added the state: fixed The bug has been fixed label Dec 12, 2021
@github-actions
Copy link

Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: fixed The bug has been fixed label Dec 25, 2021
@github-actions
Copy link

Hello @alex-w! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Projects
GUI
  
Done
Development

Successfully merging this pull request may close these issues.

ocular view: mouse dragging should be just as effective Ocular Plugin: Mouse Navigation
2 participants