-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring mouse navigation #2089
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files |
Hello @alex-w! Thank you for this enhancement. |
@gzotti I think this PR is ready to merge |
Can you move in ocular view now? Or what has changed for the user? Ah: I can move when no object is selected and centered. But when something is selected, I cannot move away using the mouse. Or yes, but I have to press the mouse button about 2 seconds until I can move the scene. This is also unexpected. |
The behaviour is connected to setting for eyepiece mode, but yes, you may disable zooming through mouse now separately |
Well, I don't observe currently. You can merge if you want because working as before is possible, but I expect bug reports with my observations about this funny behaviour that it takes some weird move to finally drag the view in Oculars view. |
Hello @alex-w! Please check the fresh version (development snapshot) of Stellarium: |
Hello @alex-w! Please check the latest stable version of Stellarium: |
Splitting the mouse navigation option into 2 options: navigation and zooming
Description
Splitting the mouse navigation option into 2 options adding the possibility to disable zooming by mouse without disabling the mouse dragging. As result we may disable zooming in the eyepiece mode in Oculars without disabling the dragging via mouse in same time.
Fixes #1317, #2086
Type of change
How Has This Been Tested?
Tested on the MacBook Pro with trackpad
Test Configuration:
Checklist: