Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate max exposure time for moving objects #2789

Merged
merged 7 commits into from
Nov 9, 2022

Conversation

alex-w
Copy link
Member

@alex-w alex-w commented Oct 29, 2022

Description

This pull request contain the implementation (optional feature) of indicate the max exposure time for the moving objects within Oculars plugin

Fixes #2752

Screenshots (if appropriate):

stellarium-001

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

github-actions bot commented Oct 29, 2022

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files

@alex-w alex-w added this to the 1.2 milestone Oct 29, 2022
@alex-w alex-w merged commit 953eb43 into master Nov 9, 2022
@alex-w alex-w deleted the oculars/max-exposure-time branch November 9, 2022 10:04
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 20, 2022
@github-actions
Copy link

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 25, 2022
@github-actions
Copy link

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@10110111
Copy link
Contributor

10110111 commented Jun 2, 2023

Does this feature assume that the telescope is installed on a tracking equatorial mount? This should be mentioned somewhere in the docs. Also, if this assumption is true, then the text should only appear for equatorial mount when the selected object is being tracked, or the computation of max exposure time should include the diurnal motion.

@gzotti
Copy link
Member

gzotti commented Jun 2, 2023

Yes, tracked mount that has been well aligned against axes, is well guided, and is in an altitude range to not suffer from differential refraction, sure. It estimates duration of motion on the sphere against the stars to not exceed 1 pixel (IIRC). 15 years ago nobody would have assumed otherwise. But you can also have motorized tracking on an alt-az mount when you also counterrotate the frame, so "equatorial" is not the criterium.
Max. exposure for the sky just depends on focal length and declination. Not sure if we really must work out how long user can expose a static camera with 10mm lens when aimed at δ=60°.

@10110111
Copy link
Contributor

10110111 commented Jun 2, 2023

But you can also have motorized tracking on an alt-az mount when you also counterrotate the frame, so "equatorial" is not the criterium.

Our "Equatorial mount" checkbox controls whether the frame rotates automatically around its optical axis. Regardless of the mount axes, if the frame remains upright, as is currently rendered in stellarium with "Equatorial mount" unchecked, it can't have the same max exposure time as with equatorial mount, even when tracking an object.

But still, the whole this feature is absolutely undocumented AFAICT, so I couldn't even learn about any assumptions that this rather ambiguous label implies.

@gzotti
Copy link
Member

gzotti commented Jun 2, 2023

It appears that all frame labels are not documented. My hope with in-master guide sources was that features are documented by the respective developers as they are added. :-/

@gzotti
Copy link
Member

gzotti commented Jun 2, 2023

Mentioned in 666f775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Oculars: Indicate max exposure time for moving objects to avoid trailing
3 participants