Add a ContentManagerInterface #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first need: allowing decoration of the whole content manager
ogizanagi
commented
Jul 9, 2021
| * Set the actual content manager instance to inject in processors. | ||
| * Useful whenever this content manager is decorated in order for the processor to use the decorating one. | ||
| */ | ||
| public function setContentManager(ContentManagerInterface $contentManager): void |
Tom32i
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first need: allowing decoration of the whole content manager
Note: For existing apps, in order for decoration to work as expected, any
ContentManagertypehints and DI injection must be replaced to use theContentManagerInterface, otherwise, your custom code might not be called in every context.The
ContentManagerAwareInterfacenow usesContentManagerInterfaceas its typehints instead ofContentManager. That should not be an issue if you use theContentManagerAwareTraitthough.