fix(connector-jdbc): remove unnecessary join on nested filter #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using nested filter on an id, the relation table already owns the if columns, so there is no need for an additional join. Check that the only column we're filtering on is id, then rewrite the condition and remove the join.
juliendangers
force-pushed
the
fix/improve-sql-queries
branch
from
09d1773 to
12bff33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nested filter on an id, the relation table already have the id columns, so there is no need for an additional join. Check that the only column we're filtering on is an id, then rewrite the condition and remove the join.