Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found possible Typo/Bug #8

Closed
dsrmatze opened this issue Mar 31, 2014 · 1 comment
Closed

Found possible Typo/Bug #8

dsrmatze opened this issue Mar 31, 2014 · 1 comment

Comments

@dsrmatze
Copy link

In RootTools.java:
retry should be passed through to the startShell and startRootShell function call.

public static Shell getShell(boolean root, int timeout, int retry) throws IOException, TimeoutException, RootDeniedException {
        if (root)
            return Shell.startRootShell(timeout);
        else
            return Shell.startShell(timeout);
    }

Suggested solution:

public static Shell getShell(boolean root, int timeout, int retry) throws IOException, TimeoutException, RootDeniedException {
        if (root)
            return Shell.startRootShell(timeout, retry);
        else
            return Shell.startShell(timeout, retry);
    }

Or explain why you dont pass it through in comments

Stericson added a commit that referenced this issue Nov 25, 2014
… with Process Builder, resolved issue #8, resolved issue with shell being repeatedly closed.
Stericson added a commit that referenced this issue Nov 25, 2014
… with Process Builder, resolved issue #8, resolved issue with shell being repeatedly closed.
@Stericson
Copy link
Owner

Done, this is being passed through now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants