Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell now implements java.io.Closeable. #6

Closed
wants to merge 1 commit into from
Closed

Shell now implements java.io.Closeable. #6

wants to merge 1 commit into from

Conversation

Doctoror
Copy link

No description provided.

@Fusion
Copy link
Collaborator

Fusion commented Mar 30, 2014

Hi.
I have a concern with this:

  • Typically, I would expect a call to a CloseAble's close() to release the resources before returning; here it is not the case due to threading.
  • More importantly, a CloseAble's close() is supposed to be idempotent; I fear this will not be the case here, due to the eventual call to notifyAll()

On the other hand, your contribution forced me to have another look at this class and I realized that the close variable needs to be made volatile so that would be a welcome change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants