Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with developer information #721

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Update docs with developer information #721

merged 3 commits into from
Apr 24, 2023

Conversation

matteobachetti
Copy link
Member

Information was spread in non-intuitive places. Here it is

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #721 (580230d) into main (8561cdd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files          42       42           
  Lines        7805     7805           
=======================================
  Hits         7587     7587           
  Misses        218      218           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be useful to have the instructions for contributing directly in the docs, rather than just the reference to CONTRIBUTING.md? Or is there a good reason for that not to be on the website?

@matteobachetti
Copy link
Member Author

I feel like it would be useful to have the instructions for contributing directly in the docs, rather than just the reference to CONTRIBUTING.md? Or is there a good reason for that not to be on the website?

@dhuppenkothen yes, I was a little lazy, I admit 😅. I now copied the information to the main documentation

Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@matteobachetti matteobachetti added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit fd68627 Apr 24, 2023
@matteobachetti matteobachetti deleted the docs_update branch September 22, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants