Stored procedure execution option #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .then(function(){ | ||
| db.execute(driver.createSP3); | ||
| }); | ||
| done(); |
There was a problem hiding this comment.
You're calling done here before the completion of the db.exeutes.
The done() should be a .then() block
|
Hi Karl, I have done the changes as per your feedback. Please let me know if any changes needed. Thanks, |
| var procedure = function(){ | ||
| throw new Error('No stored procedure feature for sqlite3.'); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Removed this method
1) Code modfied to expose procedure object if it really exist 2) Replaced promises instead of callback
…o mssqldriver class iteself
1) Code modfied to read sql scripts from files 2) Replaced promises instead of callback
…be available in test/sql/ directory
|
|
||
| describe('Unhappy Stored Procedure', function() { | ||
|
|
||
| it('should through error if not a valid stored procedure', function(done) { |
cookie-bytes
added a commit
that referenced
this pull request
Mar 17, 2015
Stored procedure execution option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Karl,
I have added stored procedure execution option in the osql module. Also I have added test cases to test stored procedure execution.
We have an issue in mssql module itself, that is output parameter to the stored procedure is not getting result back in the results. I have raised an ticket for this issue(tediousjs/node-mssql#133) .
Please share your review comments,
Note:- I'll update readme document after your review comments.
Thanks,
Dharma.