Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for empty list of nodal attributes for fort.15 #1274

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Added support for empty list of nodal attributes for fort.15 #1274

merged 4 commits into from
Mar 25, 2024

Conversation

jasonfleming
Copy link
Collaborator

resolves #1272 resolves #1273

@jasonfleming
Added support for empty list of nodal attributes to activate in fort.…
d7963b2 
…15; removed redundant platform specifications
@jasonfleming jasonfleming marked this pull request as ready for review March 22, 2024 15:52
wwlwpd
wwlwpd reviewed Mar 22, 2024
View reviewed changes
control_file_gen.pl Outdated Show resolved Hide resolved
@jasonfleming
Copy link
Collaborator Author

Also resolves #1276

@jasonfleming
Copy link
Collaborator Author

This is ready for review and merge (if approved).

wwlwpd
wwlwpd approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@wwlwpd wwlwpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for removing stale/duplicate code from platforms.sh

@wwlwpd wwlwpd merged commit 610bf18 into master Mar 25, 2024
@jasonfleming jasonfleming mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwlwpd wwlwpd wwlwpd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jasonfleming @wwlwpd