Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export all matchers #8

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Export all matchers #8

merged 1 commit into from
Jun 23, 2021

Conversation

Catgroove
Copy link
Contributor

It's bad practice to not export types that are returned by exported functions. It makes it very hard to work with the package except in the most basic cases.

@Catgroove Catgroove requested a review from noseglid June 23, 2021 08:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 37

  • 18 of 18 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 35: 0.0%
Covered Lines: 55
Relevant Lines: 55
💛 - Coveralls

noseglid
noseglid approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@noseglid noseglid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Catgroove Catgroove merged commit 105ba3b into master Jun 23, 2021
@Catgroove Catgroove deleted the feat/export-matchers branch June 23, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noseglid noseglid noseglid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Catgroove @coveralls @noseglid