Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for loggroup ARN's in Transfer Server #18

Merged
merged 5 commits into from
May 1, 2024
Merged

Add support for loggroup ARN's in Transfer Server #18

merged 5 commits into from
May 1, 2024

Conversation

oc-christopher-billett
Copy link
Contributor

@oc-christopher-billett oc-christopher-billett commented Apr 16, 2024 •
edited by chrischildresssg
Loading

Change description

Support added for Log Group ARN's for the Transfer server when not using Workflows

Type of change

  • Bug fix (fixes an issue)
  • [ x] New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@chrischildresssg chrischildresssg self-requested a review May 1, 2024 17:41
chrischildresssg
chrischildresssg approved these changes May 1, 2024
View reviewed changes
Copy link

@chrischildresssg chrischildresssg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@chrischildresssg chrischildresssg merged commit 7197763 into StratusGrid:main May 1, 2024
8 checks passed
@chrischildresssg chrischildresssg mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischildresssg chrischildresssg chrischildresssg approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oc-christopher-billett @chrischildresssg