Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger.warn/1 is deprecated. Use Logger.warning/2 instead #107

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

trbngr
Copy link
Contributor

@trbngr trbngr commented Jun 22, 2023

Updates Logger.warn/1 calls to Logger.warning/2

@trbngr
Copy link
Contributor Author

trbngr commented Jun 22, 2023

It appears that Logger.warning/2 was added in Elixir v1.11 but your build runner is testing really old Elixir versions.

Even the minimal version of Elixir that supports Logger.warning/2 is pretty old. Is it necessary to support such old versions of Elixir?

If you want, or need, to support them, I will have to wrap the logger call in a macro that checks version compatibility at compile time. I know this is a small macro, but it can make the code needlessly complex if you don't need to support < Elixir v1.11

@woylie
Copy link
Contributor

woylie commented Jul 10, 2023

The oldest officially supported Elixir version is 1.11 now: https://hexdocs.pm/elixir/1.15.2/compatibility-and-deprecations.html

@Strech
Copy link
Owner

Strech commented Jul 14, 2023

👋🏼 Hey folks, thanks for the issue. I think it makes sense to bump the minimum version to the oldest supported.

I'm going to push a bit into this branch and merge it ASAP 👏🏼

@Strech Strech merged commit 7caa918 into Strech:master Jul 14, 2023
@Strech
Copy link
Owner

Strech commented Jul 14, 2023

Thanks a lot for your contribution, new release was published as 0.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants