Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass verify: verify_none ssl setting explicitly to httpc calls to get rid of warnings when HTTPS and OTP 25 are used #97

Merged
merged 8 commits into from
Sep 12, 2022

Conversation

goozzik
Copy link
Contributor

@goozzik goozzik commented Sep 5, 2022

Hi. I recently upgraded to OTP 25 and started getting these warnings when avrora was trying to
fetch schemas from confluent schema registry:

iex(1)>  Avrora.HTTPClient.get("https://example.com")
Failed to serialize event. error: {:invalid, &:ssl_logger.format/1}, event: %{"@timestamp": "2022-09-05T14:05:34.391+02:00", depth: 20, message: "Description: 'Authenticity is not established by certificate path validation'\n     Reason: 'Option {verify, verify_peer} and cacertfile/cacerts is missing'\n", report_cb: &:ssl_logger.format/1}
Failed to serialize event. error: {:invalid, &:ssl_logger.format/1}, event: %{"@timestamp": "2022-09-05T14:05:34.629+02:00", depth: 20, message: "Description: 'Authenticity is not established by certificate path validation'\n     Reason: 'Option {verify, verify_peer} and cacertfile/cacerts is missing'\n", report_cb: &:ssl_logger.format/1}

(Please ignore serializing error part, this is about 'Option {verify, verify_peer} and cacertfile/cacerts is missing path).

In this PR I add missing options to :httpc calls to get rid of these warnings.

@Strech Strech added enhancement Improvement of existing functionality or request of improvement internal API Anything related to the internal API and implementations labels Sep 6, 2022
lib/avrora/http_client.ex Outdated Show resolved Hide resolved
@goozzik goozzik changed the title Pass verify: verify_peer and cacerts to get rid of warnings when HTTPS is used Pass verify: verify_none ssl setting explicitly to httpc calls to get rid of warnings when HTTPS and OTP 25 are used Sep 12, 2022
@Strech Strech merged commit 938f2a0 into Strech:master Sep 12, 2022
@Strech
Copy link
Owner

Strech commented Sep 13, 2022

Thanks for the finding @goozzik, I've release v0.24.1 💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing functionality or request of improvement internal API Anything related to the internal API and implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants