Output android translations as Kotlin Multiplatform project #640
Conversation
Migrated from the regular android project output to a multiplatform project. Bascially, `android/main` now becomes `android/androidMain` and `android/commonMain` has been added in order to deliver common translations (in kotlin class format) to other multiplatform projects.
This should build both AAR and multiplatform artifacts.
For build scripts probably there's no particular reason, but this version is used when running streaming server on android. |
But doesn't this repo only contain build scripts and no code that's ever to be executed by the streaming server? If so, there's no particular reason to stick to Node 12. I'll stick to it for now for consistency reasons, but perhaps we should consider upgrading to a newer version (in a new PR) so we can benefit from new language features that would make the code more readable and easier to maintain. |
This improves reusability accross different scripts.
They can be internal when translations are included as a sub-package but since this is a public package that's being intalled as a dependency they should be public.
It's not really needed.
Without KSP, these need to be registered manually. The DX is still good by exposing these within the package.
Contrucors and methods have a field limit of 255, according to the JVM spec. Therefore we can't use regular data classes because constructing them results in going far above this limit unfortunately. An interface to implement works better for our use-case.
|
I've marked this PR as ready. Did some profiling and the implementation with lyricist is stable in a KMM (android) app, just about the same as a custom implementation with |
this is pretty much the reason, everyone sticks to their tasks and we only upgrade things when necessary as we have way too many repos to maintain |
Migrated from the regular android project output to a multiplatform project. Basically,
android/mainnow becomesandroid/androidMainandandroid/commonMainhas been added in order to deliver common translations (in kotlin class format) to other multiplatform projects.This PR is not intended as a breaking change. Nothing should change by this PR besides added support for Kotlin Multiplatform or KMM projects that wish to add translations to their
commonMainsourceset.Marked as draft because I need to run more tests and adjust the publishing configuration.