-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output android translations as Kotlin Multiplatform project #640
Merged
Commits on Jun 10, 2023
-
Migrated from the regular android project output to a multiplatform project. Bascially, `android/main` now becomes `android/androidMain` and `android/commonMain` has been added in order to deliver common translations (in kotlin class format) to other multiplatform projects.
Configuration menu - View commit details
-
Copy full SHA for 91a8f63 - Browse repository at this point
Copy the full SHA 91a8f63View commit details
Commits on Jun 11, 2023
-
This should build both AAR and multiplatform artifacts.
Configuration menu - View commit details
-
Copy full SHA for d5080b1 - Browse repository at this point
Copy the full SHA d5080b1View commit details
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c8ad7ee - Browse repository at this point
Copy the full SHA c8ad7eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d700aa - Browse repository at this point
Copy the full SHA 3d700aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53689cf - Browse repository at this point
Copy the full SHA 53689cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b27e83 - Browse repository at this point
Copy the full SHA 0b27e83View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffdc0b0 - Browse repository at this point
Copy the full SHA ffdc0b0View commit details -
Extract escape logic into separate functions
This improves reusability accross different scripts.
Configuration menu - View commit details
-
Copy full SHA for 296c832 - Browse repository at this point
Copy the full SHA 296c832View commit details -
Don't mark KMM classes as internal
They can be internal when translations are included as a sub-package but since this is a public package that's being intalled as a dependency they should be public.
Configuration menu - View commit details
-
Copy full SHA for 2e08d95 - Browse repository at this point
Copy the full SHA 2e08d95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7254a7e - Browse repository at this point
Copy the full SHA 7254a7eView commit details -
Without KSP, these need to be registered manually. The DX is still good by exposing these within the package.
Configuration menu - View commit details
-
Copy full SHA for 2d6075a - Browse repository at this point
Copy the full SHA 2d6075aView commit details -
KMM: use interface for Strings
Contrucors and methods have a field limit of 255, according to the JVM spec. Therefore we can't use regular data classes because constructing them results in going far above this limit unfortunately. An interface to implement works better for our use-case.
Configuration menu - View commit details
-
Copy full SHA for 33c0c27 - Browse repository at this point
Copy the full SHA 33c0c27View commit details -
Configuration menu - View commit details
-
Copy full SHA for b741f28 - Browse repository at this point
Copy the full SHA b741f28View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.