Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output android translations as Kotlin Multiplatform project #640

Merged
merged 13 commits into from
Jun 18, 2023

Commits on Jun 10, 2023

  1. Add multiplatform support

    Migrated from the regular android project output to a multiplatform project. Bascially, `android/main` now becomes `android/androidMain` and `android/commonMain` has been added in order to deliver common translations (in kotlin class format) to other multiplatform projects.
    sleeyax committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    91a8f63 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. Setup basic publishing

    This should build both AAR and multiplatform artifacts.
    sleeyax committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    d5080b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    c8ad7ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3d700aa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    53689cf View commit details
    Browse the repository at this point in the history
  4. bump node project version

    TheBeastLT committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    0b27e83 View commit details
    Browse the repository at this point in the history
  5. fix typo

    TheBeastLT committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    ffdc0b0 View commit details
    Browse the repository at this point in the history
  6. Extract escape logic into separate functions

    This improves reusability accross different scripts.
    sleeyax committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    296c832 View commit details
    Browse the repository at this point in the history
  7. Don't mark KMM classes as internal

    They can be internal when translations are included as a sub-package but since this is a public package that's being intalled as a dependency they should be public.
    sleeyax committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    2e08d95 View commit details
    Browse the repository at this point in the history
  8. Remove KSP plugin from KMM project

    It's not really needed.
    sleeyax committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    7254a7e View commit details
    Browse the repository at this point in the history
  9. KMM: write translations map

    Without KSP, these need to be registered manually. The DX is still good by exposing these within the package.
    sleeyax committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    2d6075a View commit details
    Browse the repository at this point in the history
  10. KMM: use interface for Strings

    Contrucors and methods have a field limit of 255, according to the JVM spec. Therefore we can't use regular data classes because constructing them results in going far above this limit unfortunately. An interface to implement works better for our use-case.
    sleeyax committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    33c0c27 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b741f28 View commit details
    Browse the repository at this point in the history