feat: Replace build and jobs pages with Ember app #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/knownasilya1/strider/omveild4t |
knownasilya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issues somewhere deep in the Angular chain, the job/build page stopped working. The Angular part of this project has been holding me back mainly due to its non SPA like architecture and how unsupported it is, I've started rewriting the build page in EmberJS. Ember is known for longevity and its lts policy. It's also focused on ambitious apps, which strider is. See issues #1076, #1082, #1083, etc for the issue.
The ember version uses typescript and tailwind, both upgrades. This allows us to remove jQuery and other old bootstrap dependency. Currently this upgrade just handles a few routes and you can see these have
?ember=truein the url. This quirk will eventually go away, at the moment I use it to know which version to serve.I'm not removing any old assets yet, since not everything is 100% feature complete, but at least the basics work for builds.
The goal is to remove angular 100% and rewrite APIs on the backend as we use them in the app. But those will come piecemeal as smaller PRs.