Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google translation breaks client render #395

Closed
Giuseppetm opened this issue Jul 2, 2023 · 0 comments · Fixed by #414
Closed

Google translation breaks client render #395

Giuseppetm opened this issue Jul 2, 2023 · 0 comments · Fixed by #414
Assignees
@Giuseppetm
Labels
business logic 🐧 Business logic related localization This issue is related to localization
Milestone
September 2023

Comments

@Giuseppetm
Copy link
Member

Giuseppetm commented Jul 2, 2023 •
edited
Loading

Environment

Mobile, android

Steps to replicate

  1. /courses
  2. Set language to english
  3. Translate with google from english to italian
  4. Navigate to /groups with the card button
@Giuseppetm Giuseppetm self-assigned this Jul 2, 2023
@Giuseppetm Giuseppetm added localization This issue is related to localization business logic 🐧 Business logic related labels Jul 2, 2023
@Giuseppetm Giuseppetm added this to the September 2023 milestone Jul 2, 2023
Giuseppetm added a commit that referenced this issue Sep 21, 2023
@Giuseppetm
Fix google translation break client render
a45b9ae 
#395
@Giuseppetm Giuseppetm mentioned this issue Oct 22, 2023
Merged
Giuseppetm added a commit that referenced this issue Oct 22, 2023
@Giuseppetm
New APIs implementation and various enhancements (#414)
a15f23c 
* Handle extra groups APIs response on /groups section

Remove old models no longer needed
Restructure group items components

* Replace underscores with hyphens front-end side

Handle eventual redirects

* Update [slug].tsx

* Better typing in GroupItem component

* Remove university groups images

* Handle students associations results

Add correct image URL to extra groups

* Update Requests.ts

* Update Faq.ts

* Update some models

* Some fixes

Fix group types visualization on /courses page
Add sticky behaviour to rules sub headers (#406)
Add global state for header pin state
Update metadata for university section

* Groups section overhaul

#409

* Pages UI/UX and performance overhaul

Improve performance
Improve group types selector
Improve subheaders behaviour in degree page
Improve UX and degree resources research
Improve services page

#352 #407 #404

* Fix google translation break client render

#395

* Restructure organization page

* Improve typography

* Update organization.tsx

* Setup new endpoint for featured groups

* Format users_count number for groups cards

* Improve cards style in services page

* Update organization.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Giuseppetm Giuseppetm

Labels
business logic 🐧 Business logic related localization This issue is related to localization
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

New APIs implementation and various enhancements StudentiUniMi/website
1 participant
@Giuseppetm