Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing #29

Closed
timprepscius opened this issue Jan 23, 2013 · 2 comments
Closed

failing #29

timprepscius opened this issue Jan 23, 2013 · 2 comments

Comments

@timprepscius
Copy link

Hey there,

The library you are basing your Zip lib on doesn't work all of the time.
Which is unfortunate.

If you can get the following to work, I would really really really really really (and more reallys, really) be interested.

I'm going to try to paste an example of failure, not sure if this will work.

Well, that didn't work at all, lt me see if I can post it somewhere.

http://pastebin.com/UVU3vmxf

@dduponchel
Copy link
Collaborator

Thanks for the report and the working (failing) example. The fact that it fails for every compression level makes it worse than #22.

I played with your example and a

for(var i = 1; i < ref.length; i++) {
    inflate(deflate(ref.slice(0, i)));
}

to see if a pattern of bytes could explain the issue, without luck : about 4% of the substrings fail the test, without any obvious pattern (i=4368 is ok, i from 4369 to 4372 is not, i=4373 is ok again for example).

I'll see if I can find an other DEFLATE library which doesn't use ArrayBuffers (thanks IE).

@Stuk
Copy link
Owner

Stuk commented Oct 5, 2013

Fixed in #56

@Stuk Stuk closed this as completed Oct 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants