New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Array in JSZip#load. #252

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Projects
None yet
2 participants
@dduponchel
Collaborator

dduponchel commented Jan 19, 2016

In #250 case, we don't have fancy Uint8Array but we have an unsupported
binary format. An array of bytes (numbers between 0 and 255) is the
lowest common denominator. A binary string would awkward to build here
and building it reliably can be tricky (without filling the stack or
taking too much time/memory).
This commit adds the missing arrayReader needed here.

Add support of Array in JSZip#load.
In #250 case, we don't have fancy Uint8Array but we have a unsupported
binary format. An array of bytes (numbers between 0 and 255) is the
lowest common denominator. A binary string would awkward to build here
and building it reliably can be tricky (without filling the stack or
taking too much time/memory).
This commit adds the missing `arrayReader` needed here.

@dduponchel dduponchel referenced this pull request Mar 6, 2016

Merged

Handle prepended data. #266

Stuk added a commit that referenced this pull request Mar 9, 2016

Merge pull request #252 from dduponchel/arrayReader
Add support of Array in JSZip#load.

@Stuk Stuk merged commit ed59b0c into Stuk:master Mar 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dduponchel dduponchel deleted the dduponchel:arrayReader branch Mar 11, 2016

@dduponchel dduponchel referenced this pull request Mar 22, 2016

Merged

Release v2.6.0 #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment