New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle prepended data. #266

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Projects
None yet
1 participant
@dduponchel
Collaborator

dduponchel commented Mar 6, 2016

In some cases (crx files for example), data have been prepended but the
offset didn't change: the previous version read 0 file, didn't check it
and stopped.
This version tries harder to recover from a bad offset. If/when we read
0 file, we will throw an error.

Other tools (unzip, 7zip, etc) handle that case, now JSZip too.

Fix #265.

@dduponchel

This comment has been minimized.

Show comment
Hide comment
@dduponchel

dduponchel Mar 6, 2016

Collaborator

This pull request changes readers, like #252. Merging one means updating the other.

Collaborator

dduponchel commented Mar 6, 2016

This pull request changes readers, like #252. Merging one means updating the other.

Handle prepended data.
In some cases (crx files for example), data have been prepended but the
offset didn't change: the previous version read 0 file, didn't check it
and stopped.
This version tries harder to recover from a bad offset. If/when we read
0 file, we will throw an error.

Other tools (unzip, 7zip, etc) handle that case, now JSZip too.

Fix #265.

dduponchel added a commit that referenced this pull request Mar 21, 2016

@dduponchel dduponchel merged commit eed21cb into Stuk:master Mar 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dduponchel dduponchel deleted the dduponchel:crx_issue_265 branch Mar 21, 2016

@dduponchel dduponchel referenced this pull request Mar 22, 2016

Merged

Release v2.6.0 #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment