Handle prepended data. #266

Merged
merged 1 commit into from Mar 21, 2016

Projects

None yet

1 participant

@dduponchel
Collaborator

In some cases (crx files for example), data have been prepended but the
offset didn't change: the previous version read 0 file, didn't check it
and stopped.
This version tries harder to recover from a bad offset. If/when we read
0 file, we will throw an error.

Other tools (unzip, 7zip, etc) handle that case, now JSZip too.

Fix #265.

@dduponchel
Collaborator

This pull request changes readers, like #252. Merging one means updating the other.

@dduponchel dduponchel Handle prepended data.
In some cases (crx files for example), data have been prepended but the
offset didn't change: the previous version read 0 file, didn't check it
and stopped.
This version tries harder to recover from a bad offset. If/when we read
0 file, we will throw an error.

Other tools (unzip, 7zip, etc) handle that case, now JSZip too.

Fix #265.
b0e58c2
@dduponchel dduponchel merged commit eed21cb into Stuk:master Mar 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dduponchel dduponchel deleted the dduponchel:crx_issue_265 branch Mar 21, 2016
@dduponchel dduponchel referenced this pull request Mar 22, 2016
Merged

Release v2.6.0 #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment