Prevent crash when trying to export all decks #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash was caused by the warning dialog, itself! The issue was that export is now run in a background thread, but GUI operations from a background thread cause a crash. AnkiModalNotifier is used in `anki_exporter_wrapper.py` and `github_importer.py`. The former is in a background thread, the latter in the main thread. In both cases, error messages are now correctly displayed, without crashing. Tested on Anki 2.1.40 and 2.1.43.
Stvad
reviewed
Jun 4, 2021
|
hey, apologies for the delay getting back to this. have some big changes in life that I'm focusing on. should be able to review both your PR's now though! |
The attempted run times (in ms) will be (0, 100, 200, 300). A timeout of 0 does not seem to be used anywhere in the main Anki codebase, but is valid: https://doc.qt.io/qt-5/qtimer.html#details
|
No problem! Good luck with the life changes! Thanks for your review here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #128.
The crash was caused by the warning dialog, itself! The issue was that export is now run in a background thread, but GUI operations from a background thread cause a crash.
AnkiModalNotifier is used in
anki_exporter_wrapper.pyandgithub_importer.py. The former is in a background thread, the latter in the main thread. In both cases, error messages are now correctly displayed, without crashing.Tested on Anki 2.1.40 and 2.1.43.
For comparison / a similar issue see.
I'm not very happy about the solution — particularly the timer — but without the timer
run_on_mainresults in some sort of weird deadlock and I can't think of a better method.