Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow testing building crowd_anki/dist when Pipfile.lock is changed #195

Merged
merged 2 commits into from
May 21, 2023

Conversation

aplaice
Copy link
Collaborator

@aplaice aplaice commented May 18, 2023

The uploaded artifact is currently unused.

Fix #182.

We check for changes to both Pipfile and Pipfile.lock to avoid stale a Pipfile.lock.

This will result in some false positive runs of this workflow, when we've, say, added a new script to Pipfile, without changing dependencies.

We will also have false positives when only dev dependencies have been updated.

@aplaice aplaice force-pushed the fetch_dependencies_github_action branch from 54357e1 to 17fcf00 Compare May 18, 2023 15:16
Fix Stvad#182.

The uploaded artifact is currently unused.

We check for changes to both Pipfile and Pipfile.lock to avoid stale a
Pipfile.lock.

This will result in some false positive runs of this workflow, when
we've, say, added a new script to Pipfile, without changing
dependencies.

We will also have false positives when only dev dependencies have been
updated.
@aplaice aplaice force-pushed the fetch_dependencies_github_action branch from 17fcf00 to 7317130 Compare May 18, 2023 15:25
@aplaice aplaice force-pushed the fetch_dependencies_github_action branch from bee0d4d to 26f1ba8 Compare May 18, 2023 15:39
@aplaice aplaice merged commit 2f8e840 into Stvad:master May 21, 2023
@aplaice aplaice deleted the fetch_dependencies_github_action branch May 21, 2023 18:06
@aplaice
Copy link
Collaborator Author

aplaice commented May 21, 2023

Ugh, that didn't work (see:

https://github.com/Stvad/CrowdAnki/actions/runs/5040054106/jobs/9038569945?pr=194
)

(Process substitution (<()) issues?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for running fetch_dependencies.sh (building dist/)
1 participant