Use different divider for Gen 2 power meters #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hakana Any plans on merging this? I'm having the same issue with total power consumption for Gen 2 devices. |
|
Will be a release with it tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are different reports discussing a invalid reported
total_consumptionfor Shelly Plus devices. I think the root cause of this issue is that pyShelly divides the obtained data by 60 and, thus, converting from Wh to Wm. ShellyForHass assumes that the unit is Wh.This PR changes the divider for Gen 2 devices. While the other reports only mentioned Gen 2 devices, I assume that the previous generation might also be affected but I do not have any of those devices. Therefore, the patch only applies this change to Gen 2. Please note that I am not experienced with this code base, so my approach might be not the right one but it could hint to a solution that would fix this issue.