+ faster external links check, minor content fixes

Author: SubPointSupport

.build-helpers.ps1

@@ -27,43 +27,13 @@ function Require-Variable($value, $description) {
     if($value -eq $null) {
         throw "Variable is null: $description"
     }
-
 }
 
 function Edit-ValueInFile($path, $old, $new) {
     (Get-Content $path).replace( $old, $new ) `
         | Set-Content $path
 }
 
-function Confirm-NpmModule($name, $global = $False) {
-    
-    $needInstall = $False
-
-    try {
-        npm config set error
-            
-        if( $global -eq $True) {
-            npm list $name -g | out-null
-        } else {
-            npm list $name | out-null
-        }
-    } catch {
-        $needInstall = $True
-    }
-
-    if ($LASTEXITCODE -ne 0 -or $needInstall -eq $True) {
-        Write-Build Yellow "[~] installing npm module: $name"
-        if( $global -eq $True) {
-            npm install $name -g --silent
-        } else {
-            npm install $name --silent
-        }
-    }
-    else {
-        Write-Build Green "[+] npm module installed: $name"
-    }
-} 
-
 function Copy-NetlifyConfig {
     Copy-Item "$dirPath/netlify/*" "$buildFolder/" -Recurse -Force
 }

.build.ps1

@@ -33,7 +33,10 @@ task NpmInstall {
 
 task NetlifyInstall {
     if($null -eq (Get-Command netlify -ErrorAction SilentlyContinue) ) {
-        Confirm-NpmModule 'netlify-cli' $true
+        npm config set error
+
+        npm install netlify-cli -g --silent
+        npm install typescript  -g --silent
     } else {
         Write-Build Green "[+] netlify-cli"
     }
@@ -230,6 +233,7 @@ task NetlifyRepublish DefaultBuild, NetlifyPublish
 task Appveyor AppveyorPrepare, 
     NpmInstall, 
     NetlifyInstall,
+    ShowTools,
     DefaultBuild, 
     CreateZipArchive, 
     NetlifyPrePublish, 

docs/spmeta2/getting-started/Releases.md

@@ -16,7 +16,7 @@ We tend to be agile and deliver new features and fixes as soon as possible:
 
 * On weekly basis new features and minor fixes are published as -beta to NuGet
 * On monthly basis a major release is published to [NuGet](https://www.nuget.org/profiles/SubPointSupport)
-* Every commit to github [gets build with Appveyor](https://ci.appveyor.com/project/SubPointSupport/spmeta2) and the gets published to the [staging MyGet feed](https://www.myget.org/gallery/subpointsolutions-staging)
+* Every commit to github [gets build with Appveyor](https://www.appveyor.com) and the gets published to the [staging MyGet feed](https://www.myget.org/gallery/subpointsolutions-staging)
 
 ###  Planning and feature requiests
 We tend to use scrum and weekly iterations, aligning our roadmap with the comnunity using the following channels:
@@ -143,10 +143,9 @@ AssemblyFileVersion: 1.2.15334.1243
 
 ####  Support & Issue Resolution
 
-In case you have unexpected issues please contact support on SPMeta2 Yammer or YouTrack:
+In case you have unexpected issues please contact support on SPMeta2 Yammer:
 
 * https://www.yammer.com/spmeta2feedback
-* https://subpointsolutions.myjetbrains.com/youtrack/issues
 
 <hr />
 
@@ -230,10 +229,9 @@ AssemblyFileVersion: 1.2.15321.0933
 
 ####  Support & Issue Resolution
 
-In case you have unexpected issues please contact support on SPMeta2 Yammer or YouTrack:
+In case you have unexpected issues please contact support on SPMeta2 Yammer:
 
 * https://www.yammer.com/spmeta2feedback
-* https://subpointsolutions.myjetbrains.com/youtrack/issues
 
 <hr />
 
@@ -270,10 +268,9 @@ AssemblyFileVersion: 1.2.15306.0935
 
 ####  Support & Issue Resolution
 
-In case you have unexpected issues please contact support on SPMeta2 Yammer or YouTrack:
+In case you have unexpected issues please contact support on SPMeta2 Yammer:
 
 * https://www.yammer.com/spmeta2feedback
-* https://subpointsolutions.myjetbrains.com/youtrack/issues
 
 <hr />
 
@@ -334,10 +331,9 @@ AssemblyFileVersion: 1.2.15301.0536
 
 ####  Support & Issue Resolution
 
-In case you have unexpected issues please contact support on SPMeta2 Yammer or YouTrack:
+In case you have unexpected issues please contact support on SPMeta2 Yammer:
 
 * https://www.yammer.com/spmeta2feedback
-* https://subpointsolutions.myjetbrains.com/youtrack/issues
 
 <hr />
 
@@ -492,9 +488,8 @@ The following information aims to provide an overview on assembly related change
 
 Please review it carefully, consider that depending on your solution and API usage additional effort might be required to get updated to v1.2.XXX. Once updated, make sure your solution can be compiled without errors, then give a few rounds of provision.
 
-In case you have unexpected issues please contact support on SPMeta2 Yammer or YouTrack:
+In case you have unexpected issues please contact support on SPMeta2 Yammer:
 * https://www.yammer.com/spmeta2feedback
-* https://subpointsolutions.myjetbrains.com/youtrack/issues
 
 AssemblyFileVersion - 1.2.15265.2146
 
@@ -527,9 +522,8 @@ Current test coverage is split into three major categories:
 * Scenario based definition provision - manually written provision to cover various real word provision scenarios. Validation process is the same - deploy several times, check, changes, deploy and check again.
 
 ####  Support & Issue Resolution
-In case you have unexpected issues please contact support on SPMeta2 Yammer or YouTrack:
+In case you have unexpected issues please contact support on SPMeta2 Yammer:
 * https://www.yammer.com/spmeta2feedback
-* https://subpointsolutions.myjetbrains.com/youtrack/issues
 
 <hr />
 

tests/run-broken-link-checker.js

@@ -5,9 +5,20 @@ const colors = require('colors');
 const siteUrl = process.env.SITE_URL || "http://localhost:3000";
 const reportStep = parseInt(process.env.REPORT_STEP) || 1000;
 
+const showInternal = process.env.SHOW_INTERNAL_RESULTS == '1';
+const showExternal = (process.env.SHOW_EXTERNAL_RESULTS || "1") == '1';
+
 var options = {
     excludedKeywords: [
         'linkedin',
+        'twitter.com',
+        'www.netlify.com',
+        'https://docusaurus.io',
+        'https://www.yammer.com/spmeta2feedback',
+        'http://subpointsolutions.com',
+        'appveyor.com',
+        'myget.org',
+        
         'https://github.com/SubPointSolutions/subpointsolutions-docs',
 
         // external links
@@ -32,8 +43,14 @@ var options = {
         '1stquad.com',
         'hersheytech.com',
         'blogs.msdn.com',
-        'hekstra.org'
-
+        'hekstra.org',
+        'http://www.boostsolutions.com',
+        'msdn.microsoft.com',
+
+        // external links 
+        'https://github.com/SubPointSolutions/spmeta2/issues',
+        'https://github.com/SubPointSolutions',
+        'https://medium.com/@SubPointSocial',
     ]
 }
 
@@ -45,21 +62,34 @@ var linksCount = 0;
 var siteChecker = new blc.SiteChecker(options, {
     link: function(result, customData){
         var broken = result.broken;
-
+            
         var base = result.base.resolved;
         var target =  result.url.resolved
 
+        var brokenFlag = result.broken == true ? "[-]" : "[+]";
+        var internalFlag = result.internal == true ? "[in]" : "[ex]";
+
         if(broken == true) {
             failResults.push(result);
 
             console.log( base.yellow);
-            console.log( ("[-] "  +target).yellow );
+            console.log( (`${brokenFlag} ${internalFlag} `  + target).red );
             // console.log( result.http );
         } else {
             validResults.push(result);
 
-            // console.log(base.green);
-            // console.log( ("[+] " + target).green);
+            if(result.internal) {
+                if(showInternal) {
+                    console.log(base.yellow);
+                    console.log( (`${brokenFlag} ${internalFlag} ` + target).green);
+                }
+            } else {
+                if(showExternal)
+                {
+                    console.log(base.yellow);
+                    console.log( (`${brokenFlag} ${internalFlag} ` + target).blue);
+                }
+            }
         }      
 
         if(linksCount > 0 && linksCount % reportStep == 0) {