831 deleting stripe test connect account #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Live preview is here: http://831-deleting-stripe-test-connect-account-id.pcpink.co.uk |
| def delete_connect_account(): | ||
| if os.getenv("FLASK_ENV") != "development": | ||
| msg = {"msg": "Error. Only possible in development mode"} | ||
| return jsonify(msg), 403 |
There was a problem hiding this comment.
Nice error handling , especially the 403 return code 👍 useful for debugging
| @@ -184,5 +184,7 @@ test.describe("Subscribie tests:", () => { | |||
| // 1. Transacion filter by name and plan title | |||
| // 2. 2.A pause, resume and 2.B cancel subscription test. | |||
| order_plan_with_subscription_and_upfront_charge = require('./tests/293_subscriber_order_plan_with_recurring_and_upfront_charge'); | |||
|
|
|||
| clearing_connect_account_id = require('./tests/clear_connect_account_id.js'); | |||
There was a problem hiding this comment.
Please change to
delete_stripe_connect_account (clear rather than clearing) , (stripe to reduce ambiguity)
| @@ -0,0 +1,12 @@ | |||
| const { test, expect } = require('@playwright/test'); | |||
There was a problem hiding this comment.
Please git mv clear_connect_account_id.js delete_stripe_connect_account.js
Why?
Because that's what's happening - reduces ambiguity
|
🙌 Live preview is here: http://831-deleting-stripe-test-connect-account-id.pcpink.co.uk |
|
🚀 PR was released in |
|
🚀 PR was released in |
1 similar comment
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#831