-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove distributed
skaffold profile and chaincode*
images
#319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbcmlowk
changed the title
Chore/remove distributed skaffold
chore: remove Oct 18, 2023
distributed
skaffold profile
2 tasks
SdgJlbl
approved these changes
Oct 18, 2023
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
…he documentation Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
…d 'chaincode-init' images Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
Signed-off-by: Thibault Camalon <135698225+thbcmlowk@users.noreply.github.com>
thbcmlowk
force-pushed
the
chore/remove-distributed-skaffold
branch
from
October 19, 2023 08:09
70601ae
to
eec7713
Compare
/e2e --tests=sdk |
End to end tests: ✔️ SUCCESS Awesome sauce! |
thbcmlowk
changed the title
chore: remove
chore: remove Oct 19, 2023
distributed
skaffold profiledistributed
skaffold profile and chaincode*
images
guilhem-barthes
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
FL-1237
Description
distributed
Skaffold profile and mentions inREADME.md
chaincode-init
andchaincode
docker images and workflowsChecklist
Needs
https://github.com/owkin/substra-ci/pull/133
Substra/substra-documentation#379
Related
Substra/substra-backend#768