Add user metadata #61
Conversation
| const keys = Object.keys(metadata); | ||
|
|
||
| const li = css` | ||
| font-family: SFMono-Regular,Consolas,Liberation Mono,Menlo,Courier,monospace |
There was a problem hiding this comment.
There is a monospaceFamily variable available that you should use instead.
|
@maeldebon could you include a screenshot of your recent changes? |
That would be great! |
I updated the description |
| @@ -160,6 +169,27 @@ OwnerMetadata.defaultProps = { | |||
| owner: '', | |||
| }; | |||
|
|
|||
| export const MetadataMetadata = ({metadata}) => { | |||
| const keys = Object.keys(metadata); | |||
There was a problem hiding this comment.
I think you're missing sorted() here as well :)
| @@ -35,10 +35,13 @@ const baseDd = css` | |||
|
|
|||
| const metadataDt = css` | |||
| text-transform: initial; | |||
| font-family: ${monospaceFamily}; | |||
| margin-left: ${spacingSmall}; | |||
There was a problem hiding this comment.
You could use padding-left here, it would avoid having to specify a negative left margin the metadataDd class.
| {keys.sort().map((key) => ( | ||
| <SingleMetadata labelClassName={metadataDt} valueClassName={metadataDd} key={key} label={key} value={metadata[key]} />))} | ||
| {keys.map((key) => ( | ||
| <SingleMetadata labelClassName={metadataDt} valueClassName={metadataDd} key={key} label={`- ${key}`} value={metadata[key]} />))} |
There was a problem hiding this comment.
Including the - like this works visually, but it introduces an unwanted behavior: When selecting the key, you'll also select the -. I guess this will also be picked up by screen readers.
One solution could be to have the metadataDt updated with:
&:before {
content: '- ';
}Of course, the best solution would be to have an actual list, but in order to keep this short, the above solution should be enough.
There was a problem hiding this comment.
You're right, it will be better this way
|
Hello @maeldebon, since you're not available this week I took the liberty to add metadata to the TesttupleSummary and to fix a couple of bugs:
Excellent work otherwise! |
* Add helm chart linting * Fix typo * Add building & linting to PR approval process * Reduce validate-pr length * Auto-format * fix build * name steps * Separate build job in validate-pr for speed * Fix validate-pr workflow Co-authored-by: Jérémy Morel <jeremy.morel@owkin.com>
This PR aims to add assets' metadata field to the frontend.
These metadata are currently displayed as follows.
When there are metadata:
When there are no metadata:
