Enforce login and moderator status to edit data #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfranciscosousa
force-pushed
the
fs/add-auth
branch
from
971be1e
to
c8786c8
Compare
jpcorreia99
reviewed
Feb 5, 2021
Comment on lines
2
to
+3
| before_action :require_login, only: %i[new create edit update destroy] | ||
| before_action :require_moderator, only: %i[new create edit update destroy] |
There was a problem hiding this comment.
isn't the require_login made redundant here since require_moderator also checks if the user is logged_in?
There was a problem hiding this comment.
Require login ensures people are authenticated, redirecting them to login.
Require moderator just breaks a 401
We need both because we want the redirect part + the 401 part afterward.
|
There seems to be this stange bug where, when in the books tab, if I click on a user to see it's books, the page turns blank |
|
@jpcorreia99 not gonna solve here on this PR, not part of the scope. I'll solve that later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent people from messing up the existing data, only moderators should be able to edit data.