Improve complexity score coverage #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-1273
to
+1310
| val = min(max(stats[name], metric["clip"][0]), metric["clip"][1]) | ||
| elif isinstance(stats[name], bool): | ||
| val = 1 if stats[name] else 0 | ||
| val = min(max(stats.get(name,0), metric["clip"][0]), metric["clip"][1]) | ||
| elif isinstance(stats.get(name), bool): | ||
| val = 1 if stats.get(name) else 0 |
There was a problem hiding this comment.
Can we take these changes back out? My idea was that I'd rather have the app crash if we are using the wrong name or spelling of a metric name, and going through parse_form once with one form is enough to catch these errors. It's much easier to see the crash and fix it than to realize we've been misspelling things for a month and some values have been silently turning into 0s.
There was a problem hiding this comment.
My thought was I didn't want to break old links to cached stats
There was a problem hiding this comment.
That's fair, but we should just recompute cached stats in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in two important factors to the overall score:
Fix #87 Fix #88