Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with alkiln v3 action-controlled workflow only #37

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Conversation

plocket
Copy link
Contributor

@plocket plocket commented Jan 11, 2022

This uses only the workflow file to trigger ALKiln tests. Removed package.json and other npm files and files for local development as the ALKiln will manage these now. References the ALKiln v3 branch to keep up with updates to that branch.

Copy link
Contributor

@BryceStevenWilley BryceStevenWilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as in SuffolkLITLab/docassemble-AssemblyLine#369 (review): workflow changes are fine, but I don't see the need to delete .gitignore (more so) and .env_example (less so). Though the arguments are less strong on less active repos, e.g. anything that's not AssemblyLine core, so it's probably fine.

@plocket plocket merged commit 8b3c703 into main Jan 13, 2022
@plocket plocket deleted the alkiln_update branch January 13, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants