This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Unintended Donations AB Test #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeseniamolinab
force-pushed
the
feature.unintended-donation-abtest-v1
branch
from
c09518c
to
2d4faf2
Compare
This reverts commit 4b8e38e.
adding idMismatch to the FE data fixed ts types fixed spec fixed spec more specs fixes specs
yeseniamolinab
force-pushed
the
feature.unintended-donation-abtest-v1
branch
from
2d4faf2
to
2e374c2
Compare
yeseniamolinab
commented
Apr 20, 2022
| def id_mismatch | ||
| return false if recognized_member.nil? | ||
|
|
||
| Rails.logger.info("current is '#{current_member}' and recognized is '#{@recognized_member.id}'") |
There was a problem hiding this comment.
I added this for debugging/testing purposes and I will remove it in a follow-up PR after I test this on staging.
yeseniamolinab
commented
Apr 20, 2022
| @@ -0,0 +1,5 @@ | |||
| export default { | |||
| experimentId: 'wXDP1ynuTQKHs6vVvMEj1A', | |||
There was a problem hiding this comment.
Once the testing is done on staging, I will update the experiment id with the production Id
yeseniamolinab
commented
Apr 20, 2022
| const variant = window.google_optimize.get( | ||
| unintendedDonationsExperiment.experimentId | ||
| ); | ||
| console.log('variant', variant); |
There was a problem hiding this comment.
I added this for debugging/testing purposes, and I will remove it in a follow-up PR after testing it on staging.
yeseniamolinab
commented
Apr 20, 2022
| this.props.experiments.find( | ||
| e => (e.experimentId = unintendedDonationsExperiment.experimentId) | ||
| ) || {}; | ||
| console.log(this.props); |
There was a problem hiding this comment.
I added this for debugging/testing purposes, and I will remove it in a follow-up PR after testing it on staging.
adding experiments to the reducers config renamed store prop updated prop applying variant logic refactor - use const instead of magic string fixed spacing removed blank line if there is not recognized member then we don't have any mismatch broken build raise error for debugging added log removed console log
yeseniamolinab
force-pushed
the
feature.unintended-donation-abtest-v1
branch
from
c7ddcfd
to
f730351
Compare
yeseniamolinab
changed the title
This reverts commit 420c106.
yeseniamolinab
commented
Apr 21, 2022
| export const SET_VARIANT = 'set_variant'; | ||
|
|
||
| const initialState = { | ||
| experiments: [], |
There was a problem hiding this comment.
Using an array in case we have several experiments running at the same time in the future
osahyoun
approved these changes
Apr 22, 2022
This was referenced Apr 22, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
id_mismatchthat indicates if the current user's id differs from the recognized member of the AKID on the query string.Ticket
https://app.asana.com/0/1119304937718815/1202042895794628/f
Videos
Here's a video of variant one when there is data on the cookies about a member and then we have a link with a different AKID.
Loom.Message.-.21.April.2022.mp4
Here's variant 0 with the same scenario described above. Everything remains the same and we show the member's data from the AKID on the URL no matter what.
Loom.Message.-.21.April.2022.1.mp4