Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

Using AWS secrets manager #1956

Merged
merged 12 commits into from Jun 10, 2022
Merged

Using AWS secrets manager #1956

merged 12 commits into from Jun 10, 2022

Conversation

yeseniamolinab
Copy link
Contributor

@yeseniamolinab yeseniamolinab commented Jun 3, 2022

Overview

  • Integrating AWS secrets manager into the codebase.
    • For the secrets that had their initializer file, I added the fetching of secrets only if the env is production to avoid using the secrets manager for the test environment.
    • created a applications_secrets.rb initializer to set the env variables with the secrets from aws sm
      • I use this approach to avoid many changes in different places of the code.
      • Query the secrets multiple times (AWS will charge us every time we fetch a secret. If we set up the secrets when the application is initialized, that will lower our costs).

Ticket

https://app.asana.com/0/1119304937718815/1202224736831777/f

Notes for reviewers

The sentry DNS is different from Champaign and Pronto. I used pronto's value on the secrets manager. Therefore, Champaign will use the same; is that ok?
I noticed that we don't have any logs for Champaign on sentry; I guess that using pronto's DSN here will fix that problem, but let me know if that is not the case.

@yeseniamolinab yeseniamolinab marked this pull request as ready for review June 6, 2022 21:36
Copy link
Member

@osahyoun osahyoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@yeseniamolinab yeseniamolinab merged commit f346441 into development Jun 10, 2022
@yeseniamolinab yeseniamolinab deleted the feature.aws-secrets branch June 10, 2022 15:12
@yeseniamolinab yeseniamolinab restored the feature.aws-secrets branch June 10, 2022 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants