Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perf test script using avalanche #1025

Merged
merged 23 commits into from Oct 23, 2020
Merged

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Oct 21, 2020

Description

Add a script to run performance test in vagrant with metrics (using avalanche as metrics generator).

Usage:
TEST_DURATION=<duration_in_seconds> TEST_WARMUP_DURATION=<warmup_in_seconds> ./vagrant/scripts/perf-test.sh
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
echo "Starting perf tests"

if [[ $(is_avalanche_running) -eq 0 ]]; then
echo "Avalanche is running, stop it, wait for the collection to cool down and then rerun the test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to test collection in hot state? I would like to avoid testing during bootstraping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's fine for prometheus but doesn't give us top values for the DPM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you suggest then? To not check if avalanche is running when the test is started?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first comment i didn't though about prometheus, so I think we should do as follow

  1. check is cluster is cold
  2. measure prometheus metrics
  3. wait until cluster is hot
  4. clean up receiver-mock metrics
  5. measure receiver-mock ingest
  6. wait some time
  7. measure receiver-mock ingest
  8. measure prometheus metrics

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the condition for "cold" and "hot" cluster?

We can add second parameter to this script being the warmup period

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say 1 min for warmup is enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if current version makes sense

Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
@pmalek-sumo pmalek-sumo merged commit a86d71e into master Oct 23, 2020
@pmalek-sumo pmalek-sumo deleted the add-perf-script-with-metrics branch October 23, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants