New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perf test script using avalanche #1025
Conversation
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
echo "Starting perf tests" | ||
|
||
if [[ $(is_avalanche_running) -eq 0 ]]; then | ||
echo "Avalanche is running, stop it, wait for the collection to cool down and then rerun the test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to test collection in hot state? I would like to avoid testing during bootstraping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it's fine for prometheus but doesn't give us top values for the DPM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you suggest then? To not check if avalanche is running when the test is started?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first comment i didn't though about prometheus, so I think we should do as follow
- check is cluster is cold
- measure prometheus metrics
- wait until cluster is hot
- clean up receiver-mock metrics
- measure receiver-mock ingest
- wait some time
- measure receiver-mock ingest
- measure prometheus metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the condition for "cold" and "hot" cluster?
We can add second parameter to this script being the warmup period
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say 1 min for warmup is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if current version makes sense
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
* move metrics server chart repo * modify args for metrics-server startup * Generate new overrides yaml/libsonnet file(s). Co-authored-by: Travis CI <travis@travis-ci.org>
deploy/helm/sumologic/templates/setup/setup-custom-configmap.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏎️
Co-authored-by: Dominik Rosiek <58699848+sumo-drosiek@users.noreply.github.com>
Description
Add a script to run performance test in vagrant with metrics (using avalanche as metrics generator).
Testing performed