Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix labels, disable Fluent-Bit Helm Chart serviceMonitor, use Prometheus Operator additionalServiceMonitors to work around expectation that Prometheus Operator is already installed. #159

Merged
merged 4 commits into from
Aug 30, 2019

Conversation

frankreno
Copy link
Contributor

fix labels, disable Fluent-Bit Helm Chart serviceMonitor, use Prometheus Operator additionalServiceMonitors to work around expectation that Prometheus Operator is already installed.

…eus Operator additionalServiceMonitors to work around expectation that Prometheus Operator is already installed.
app: sumologic
release: prometheus-operator
release: collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to document to remind user to override all these hard corded value if they specify a different release name cc @maimaisie

@rvmiller89
Copy link
Contributor

rvmiller89 commented Aug 30, 2019

@frankreno I get this error trying this, maybe I'm doing something wrong?

k8s $ k get pods
No resources found.
k8s $ k get servicemonitors
No resources found.
k8s $ helm install sumologic/sumologic --name collection --namespace sumologic -f values.yaml --no-crd-hook
Error: release collection failed: servicemonitors.monitoring.coreos.com "collection-fluent-bit" already exists

Interestingly, fluentd and fluentbit do appear to work then, but only those 3 service monitors. The only targets I see in Prometheus now are

sumologic/collection-fluent-bit/0 (6/6 up) 
sumologic/collection-sumologic-events/0 (1/1 up) 
sumologic/collection-sumologic/0 (3/3 up) 

Copy link
Contributor

@maimaisie maimaisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in our CI script that if you change values.yaml in the first commit of a new branch, the overrides yamls don't get generated (tracked by this Jira https://jira.kumoroku.com/jira/browse/SUMO-117261 but I haven't got a chance to look into it yet). To workaround it, we'll need to make some changes in values.yaml in a second commit. Let me just add a newline somewhere and delete it later 😓

@rvmiller89
Copy link
Contributor

Frank and I figured out the issue I was having with "collection-fluent-bit" already exists ...

The problem is that I was applying the new values.yaml over the repository helm chart, which still had the old fluent-bit service monitor declaration, so it was trying to declare the same service monitor twice. This will be resolved once we update the repository version.

@frankreno frankreno merged commit e57dbc6 into master Aug 30, 2019
@lei-sumo lei-sumo deleted the helm-fix-servicemonitors branch August 30, 2019 20:00
selector:
matchLabels:
app: fluentd-events
- name: collection-fluent-bit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankreno this file is generated from values.yaml. is this name: collection-fluent-bit correct for the prometheus-overrides.yaml file?

@maimaisie maimaisie mentioned this pull request Aug 30, 2019
3 tasks
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
* move fastly resources to separate file

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants