Update helm readme #173
Merged
Update helm readme #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimaisie
requested review from
drduke1,
frankreno,
lei-sumo,
rvmiller89 and
samjsong
rvmiller89
approved these changes
Aug 30, 2019
drduke1
approved these changes
Aug 30, 2019
samjsong
approved these changes
Aug 30, 2019
lei-sumo
reviewed
Aug 30, 2019
|
|
||
| ```bash | ||
| curl https://raw.githubusercontent.com/SumoLogic/sumologic-kubernetes-collection/master/deploy/helm/sumologic/values.yaml | \ | ||
| sed 's/\collection-sumologic.sumologic'"/<RELEASE-NAME>-sumologic.<NAMESPACE>/g" > values.yaml | ||
| sed 's/\-sumologic.sumologic'"/-sumologic.<NAMESPACE>/g" | \ | ||
| sed 's/\collection'"/<RELEASE-NAME>/g" > values.yaml |
There was a problem hiding this comment.
would this regex for collection be too broad?
There was a problem hiding this comment.
currently it's fine, we'll need to re-evaluate it in the future maybe
psaia
pushed a commit
to psaia/sumologic-kubernetes-collection
that referenced
this pull request
May 25, 2021
* adding best seller logs for monitoring. * adding new line * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #159 user also needs to replace all occurrences of
collectionfor the override values if they use a different release name.Testing performed