-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict shapely dependency to <=2 #130
Conversation
Hi @campanelli-sunpower, just a bump, especially about cutting a new release that doesn't forbid the latest pvlib :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because pvfactors
is a library, I think we should allow upgrading of Shapely until (but not including) v2, at which point the warnings will become failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kanderso-nrel .
I suspect the test failures are caused by the numpy change discussed in pvlib/pvlib-python#1369 If that's true (need to verify it locally), I'd advocate for the same fix: weaken the test tolerance a bit to allow for the variation from numpy |
@kanderso-nrel Looks like some small numerical drift on the newer Pythons. I think it would be ok to widen the tolerance slightly. Note the recommendation here to not use
|
@campanelli-sunpower Shall I update this PR with those changes? |
@kanderso-nrel Please do so if you are ok with that. It would keep the review sequence more straightforward. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating these test methods too.
Closes #126.
I wonder if we should think about releasing 1.5.2 soon? Besides these deprecation warnings and the
tilt=0
issue from #125, it would be nice for the latest pvfactors version to allow pvlib==0.9.0 on installation. Someone asked about this on the pvlib google group: https://groups.google.com/g/pvlib-python/c/hNaNsM1pNSw