Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 refactoring pt 2 and added other daily sun events #24

Conversation

davideilmito
Copy link
Collaborator

  • Added Nautical sunrise and sunset
  • Added astronomical sunrise and sunset

@davideilmito davideilmito linked an issue Mar 25, 2023 that may be closed by this pull request
@davideilmito davideilmito added the enhancement New feature or request label Mar 25, 2023
Copy link
Member

@seldon1000 seldon1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you handle astronomical/civic... data?

@davideilmito davideilmito changed the title 23 refactoring pt 2 added other daily sun events 23 refactoring pt 2 and added other daily sun events Mar 25, 2023
@davideilmito
Copy link
Collaborator Author

davideilmito commented Mar 25, 2023

The following variables have been introduced inside Sun object:

//Date at which there is the Nautical Sunrise
public private(set) var nauticalSunrise: Date = Date()
//Date at which there is the Nautical Sunset
public private(set) var nauticalSunset: Date = Date()
   
//Date at which there is the Astronomical Sunrise
public private(set) var astronomicalSunrise: Date = Date()
//Date at which there is the Astronomical Sunset
public private(set) var astronomicalSunset: Date = Date()

@davideilmito davideilmito merged commit 6a7edda into main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring pt 2 && Adding Astronomical/Nautical Sunrise/Sunset
2 participants