Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpg signing support #31

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Add gpg signing support #31

merged 3 commits into from
Mar 26, 2024

Conversation

SuperBo
Copy link
Owner

@SuperBo SuperBo commented Mar 26, 2024

Add preliminary support for gpg signing commit. Now only support create commit with signing.

@SuperBo SuperBo merged commit 36e44db into main Mar 26, 2024
8 checks passed
@calops
Copy link

calops commented Mar 27, 2024

This adds libgpgme.so as a dependency, correct? If so, maybe the README should be updated?

@SuperBo
Copy link
Owner Author

SuperBo commented Mar 30, 2024

@calops , yes, but it adds libgpgme.so as a lazy dependency. If you don't install and don't use gpg siging, no problem is raised.

@calops
Copy link

calops commented Mar 30, 2024

The problem is that if do use gpg signing, the plugin stops being able to commit all of a sudden, without having to enable anything in its configuration. That doesn't make it a lazy dependency in my opinion.

@SuperBo
Copy link
Owner Author

SuperBo commented Mar 30, 2024

Thank you @calops, and sorry for disturbing your workflow 🙇. I updated README, let me know if I missed anything else!

@calops
Copy link

calops commented Mar 30, 2024

No worries 👍
It wasn't hard to figure out the issue anyway since the error message mentions the dependency. But maybe it would be better for the plugin itself to detect if that dependency is present and then prompt a proper warning to the user if they're using gpg signing?

@SuperBo
Copy link
Owner Author

SuperBo commented Mar 30, 2024

@calops, Sure, I will revise all error logging and warning. Need to finish some other features first.

@SuperBo SuperBo deleted the add-gpg-signing branch April 4, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants