Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.0 #7

Merged
merged 47 commits into from
Aug 31, 2020
Merged

Release 1.0 #7

merged 47 commits into from
Aug 31, 2020

Conversation

mts299
Copy link
Collaborator

@mts299 mts299 commented Jul 28, 2020

This code should work exactly like pyDARN io code as I just copied it over and changed all pyDARN to pyDARNio.

import pydarnio

is how to use the library.

mts299 and others added 25 commits June 30, 2020 12:18
@mts299
merged pyDARN's develop to pyDARNio and convert some things
4490d20
@mts299
added pyDARN documentation
00cc614
@mts299
convert pyDARN to pyDARNio
a6fa148
@mts299
switched pydarn to pydarnio
24d5bda
@mts299
switched pyDARN to pyDARNio
656070e
@mts299
switched SDARNRead documentation to pyDARN to pyDARNio
9148579
@mts299
switched citing documentation to pyDARN to pyDARNio
0b60dfe
@mts299
switched install documentation to pyDARN to pyDARNio
c4c771c
@mts299
removed deprecation warnings
29cd158
@mts299
converted another pyDARN to pyDARN io
b41af7a
@mts299
converted another pyDARN to pyDARN io
49d5934
@mts299
rename pyDARNio to pydarnio to keep simple for python importing
7f9e794
@mts299
mass converting to pyDARN to pyDARNio
dde37fc
@mts299
editted the about on pyDARNio
b24b7e8
@mts299
more converting
c05c74e
@mts299
updated pydarnio name
d757837
@mts299
converting pyDARNio to pydarnio in importting
e0bc57b
@mts299
added utils from pydarn
2bc969c
@mts299
convert pyDARNio to pydarn for dmap
a02cc6f
@mts299
added in long discription code
cc83899
@mts299
added the logo
3dd34db
@mts299
updated the README
61cd0ef
@mts299
trying to get the logo to work
3dbfb57
@mts299
fixed pyDARNio logo on readthedocs
a7a74c6
@mts299
added two more files from pyDARN that are handy to have
d85876d
@mts299
Copy link
Collaborator Author

mts299 commented Jul 29, 2020

read the docs link: https://pydarnio.readthedocs.io/en/release-1.0/

@mardet987
Copy link
Collaborator

mardet987 commented Jul 30, 2020 •
edited
Loading

@mts299 getting similar issue to pydarn v1.1 release I think it may have been missed here:

File "/home/radar/pydarnio-env/lib/python3.6/site-packages/pydarnio-1.0.0-py3.6.egg/pydarnio/borealis/borealis_convert.py", line 242, in init
File "/home/radar/pydarnio-env/lib/python3.6/site-packages/pydarnio-1.0.0-py3.6.egg/pydarnio/borealis/borealis_convert.py", line 316, in _write_to_sdarn
File "/home/radar/pydarnio-env/lib/python3.6/site-packages/pydarnio-1.0.0-py3.6.egg/pydarnio/dmap/superdarn.py", line 620, in write_rawacf
AttributeError: type object 'Rawacf' has no attribute 'extra_fields'

@mts299
Copy link
Collaborator Author

mts299 commented Jul 30, 2020

Whoops, just fixed it @mardet987

@aburrell @mardet987
DOC: update docs/user/BorealisIO.md
9e0abdd 
Adapted language for clarity.

Co-authored-by: mardet987 <mardet987@users.noreply.github.com>
aburrell
aburrell reviewed Aug 12, 2020
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
tests/unit/test_conversions.py Outdated Show resolved Hide resolved
tests/unit/test_dmap.py Show resolved Hide resolved
aburrell
aburrell reviewed Aug 13, 2020
View reviewed changes
pydarnio/dmap/dmap.py Outdated Show resolved Hide resolved
pydarnio/dmap/dmap.py Outdated Show resolved Hide resolved
pydarnio/dmap/superdarn.py Outdated Show resolved Hide resolved
tests/integration/test_borealis.py Outdated Show resolved Hide resolved
tests/integration/test_superdarn.py Outdated Show resolved Hide resolved
pydarnio/borealis/borealis_array.py Outdated Show resolved Hide resolved
pydarnio/borealis/borealis_convert.py Outdated Show resolved Hide resolved
pydarnio/borealis/borealis_convert.py Outdated Show resolved Hide resolved
pydarnio/borealis/borealis_convert.py Outdated Show resolved Hide resolved
pydarnio/borealis/borealis_convert.py Outdated Show resolved Hide resolved
mts299
mts299 commented Aug 25, 2020
View reviewed changes
docs/user/install.md Outdated Show resolved Hide resolved
mts299 and others added 7 commits August 25, 2020 10:03
@mts299 @aburrell
Apply suggestions from code review
a564bcd 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@mts299
cleaned up docstrings
9beaff8
@mts299 @aburrell
Update tests/integration/test_superdarn.py
f45826a 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@mts299
removed main function
53a2195
@mts299
Merge branch 'release-1.0' of github.com:SuperDARN/pyDARNio into rele…
b746b05 
…ase-1.0
@mts299 @aburrell
Update tests/unit/test_superdarn.py
f9b9cbd 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@mts299
Update docs/user/install.md
652400b
@mts299
Copy link
Collaborator Author

mts299 commented Aug 25, 2020

@mardet987 if you want to love over the comments from @aburrell and add any you see fit to. Then I think we are good to merge and release :)

mardet987 and others added 2 commits August 25, 2020 14:56
@mardet987
@aburrell code review, mainly style updates
d37b9fc 
- setUp before other functions in testing classes
- See Also documentation after other sections but before Notes
- math.fmod, math.floor -> np.fmod, np.floor to reduce imports
- removed single-char variable 'e' for error
@aburrell @mts299
MAINT: fix name
c2a7c97 
Fixed name and capitalization to reflect current package and be consistent.

Co-authored-by: Marina Schmidt <mts299888@gmail.com>
aburrell
aburrell reviewed Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found two typos. I will not have time to do the unit tests for probably a month, but there's an issue now so the problems won't be buried if you want to tag that for a future release.

pydarnio/dmap/superdarn.py Outdated Show resolved Hide resolved
pydarnio/dmap/superdarn.py Outdated Show resolved Hide resolved
mts299 and others added 2 commits August 26, 2020 08:51
@mts299 @aburrell
Update pydarnio/dmap/superdarn.py
83f5892 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@mts299 @aburrell
Update pydarnio/dmap/superdarn.py
94fb70b 
Co-authored-by: Angeline Burrell <aburrell@users.noreply.github.com>
@mts299
Copy link
Collaborator Author

mts299 commented Aug 26, 2020

@mardet987 did you get all the reviews done if so I can release it today.

@mardet987
Copy link
Collaborator

I have some unit tests not passing now .... so I'm looking into it .

@mardet987
Reshape and flatten site array functions
fdc7cce 
edited to not work on the records dictionary in place.
This is needed so they don't edit the records dictionary
of the class whenever the arrays is accessed, for example.
@mardet987
edited tests to account for checking NaNs
cc24783 
NaN==NaN returns False so have to use np.isNaN
to check for these in arrays. These are found where
the dimension of the array is greater than the dimension
for that record. (ie. max num sequences may be larger than
num sequences for a specific record).
@mardet987
Merge branch 'release-1.0' of https://github.com/superdarn/pydarnio i…
50ed9e1 
…nto release-1.0
@mardet987
flake8 linting
3c1cae8
@mardet987
Copy link
Collaborator

Sorry, I'm not sure how I didn't see these integration tests not passing before. I have made some edits, now the Borealis tests pass.

@mts299 mts299 merged commit 4e274f4 into master Aug 31, 2020
@egthomas egthomas deleted the release-1.0 branch August 24, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aburrell aburrell aburrell left review comments

@mardet987 mardet987 mardet987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mts299 @mardet987 @aburrell