Append "Flat" to "OriginalFixedImage/fixedImageOriginal" Direction identifiers, replace some this->
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a type is only used once, it is not necessary to add an alias.
Renamed the `m_OriginalFixedImageDirection` data members of ElastixBase and ElastixMain to `m_OriginalFixedImageDirectionFlat`, according to their corresponding Set and Get member functions.
Renamed local `fixedImageOriginalDirection` variables and data members to `fixedImageOriginalDirectionFlat`, to clarify that they are a "flat" representation of a direction matrix.
Following C++ Core Guidelines, May 11, 2024: "Avoid `protected` data", https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rh-protected Follow-up to commit 1e28a4e
The prefix `this->` is not necessary when a class accesses its own private data. Follow-up to commit 7618fa3
Clarified where those data member are from.
The prefix `this->` is not necessary when a class or template just accesses its own private data. Follow-up to commit 7618fa3
Clarified where those data member are from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few style improvements to improve readability of the code related to the flat representation of the direction of the fixed image.