ENH: Add 4D float support #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More something for @stefanklein to comment on. I am not sure we should change this default value. It is also possible to set this cmake flag externally when building elastix. Just override this cmake option for ITKELastix. |
stefanklein
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
To me it seems a good idea to enable it by default, if that's what ITKElastix requires as well, in order to keep things simple (instead of having different defaults for command-line and itkelastix). The only downside of adding "float" here is that compilation time increases. The advantage is that users who have sufficient memory can use the floating point precision without having to compile elastix themselves.
|
agreed then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.