-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalyst Support #75
Catalyst Support #75
Conversation
@@ -467,17 +467,6 @@ extension TrackingServiceTableViewController { | |||
// references | |||
_ = session.start() | |||
authenticationSessionReference = session | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably re-add this, it was crashing on catalyst so I just removed it all then didn't bother adding it back when I added the #available check
@@ -2,15 +2,6 @@ | |||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | |||
<plist version="1.0"> | |||
<dict> | |||
<key>com.apple.developer.associated-domains</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to remove associated domains because free dev account doesn't support it
I haven't removed the Cartfile, but it's probably a good idea to remove it so there's nothing left of Carthage. The project also uses modified OpenCastSwift which is here https://github.com/FaizanDurrani/OpenCastSwift |
@FaizanDurrani One feature that I suggest is to implement the Touch Bar to navigate in Watch Next,Fetatured ... |
I am not entirely sure if that’s possible with catalyst. You’d have to rewrite the whole program with AppKit to get Mac specific stuff. |
Closing in favor of the spm branch. |
It works but probably could use code cleanup