Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalyst Support #75

Closed
wants to merge 3 commits into from
Closed

Conversation

FaizanDurrani
Copy link

It works but probably could use code cleanup

- Removed Carthage
- Converted all dependencies to Swift Package Manager
- Added checks for HomeKit framework for Catalyst
@@ -467,17 +467,6 @@ extension TrackingServiceTableViewController {
// references
_ = session.start()
authenticationSessionReference = session
} else {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably re-add this, it was crashing on catalyst so I just removed it all then didn't bother adding it back when I added the #available check

@@ -2,15 +2,6 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.developer.associated-domains</key>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to remove associated domains because free dev account doesn't support it

@FaizanDurrani
Copy link
Author

FaizanDurrani commented Mar 27, 2020

I haven't removed the Cartfile, but it's probably a good idea to remove it so there's nothing left of Carthage.

The project also uses modified OpenCastSwift which is here https://github.com/FaizanDurrani/OpenCastSwift

@Catta1997
Copy link
Contributor

@FaizanDurrani One feature that I suggest is to implement the Touch Bar to navigate in Watch Next,Fetatured ...

@FaizanDurrani
Copy link
Author

@FaizanDurrani One feature that I suggest is to implement the Touch Bar to navigate in Watch Next,Fetatured ...

I am not entirely sure if that’s possible with catalyst. You’d have to rewrite the whole program with AppKit to get Mac specific stuff.

@SuperMarcus SuperMarcus changed the base branch from master to spm April 20, 2020 04:22
@SuperMarcus
Copy link
Owner

Closing in favor of the spm branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants