Add helm chart #111
Closed
Add helm chart #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jochem Bruijns <jochem.bruijns@cyso.com>
|
Maybe this would be a better fit for https://github.com/prometheus-community/helm-charts? This way all of the automated testing tooling is available. |
|
Thanks for the suggestion. I have never contributed there before, but i'll see if I'm able to meet the requirements. I'll have to change some stuff with regards to versioning I think. Are there any other things you would think need attention before it could be merged? |
|
I'm not totally up on the standards used in that repo. But it's a nice collection, which makes it easier for people to find this. |
|
I'll give it a shot! Go ahead and close this request. Thanks!
…On Tue, Jul 4, 2023, 17:38 Ben Kochie ***@***.***> wrote:
I'm not totally up on the standards used in that repo. But it's a nice
collection, which makes it easier for people to find this.
—
Reply to this email directly, view it on GitHub
<#111 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AICC6QHU2CMVKJAXBROYKWDXOQ2GTANCNFSM6AAAAAAZ5ZGCKA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a Helm chart in the following repository: https://github.com/cyso/helm-smokeping-prober
I figured it might be better to contribute it to the source project. If you want to @SuperQ, then go ahead and merge it into this project, i'll then either archive or delete the other repository.