This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorvargasdev
force-pushed
the
feat/add-support-to-multi-channels
branch
from
April 18, 2024 18:06
e16eee5
to
41de2c8
Compare
vitorvargasdev
changed the title
feat/add support to multi channels
feat: add support to multi channels
Apr 18, 2024
carlossantos74
suggested changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, but we need to improve. There are things you need to do.
- Create an enum for the channel state. Initially it can be
connecting
,connected
anddisconnected
; - Remove the component state type from the channel;
- Add the component state to the component;
vitorvargasdev
force-pushed
the
feat/add-support-to-multi-channels
branch
from
April 19, 2024 22:47
41de2c8
to
9266987
Compare
vitorvargasdev
force-pushed
the
feat/add-support-to-multi-channels
branch
from
April 19, 2024 23:00
9266987
to
3b0da9d
Compare
vitorvargasdev
force-pushed
the
feat/add-support-to-multi-channels
branch
from
April 21, 2024 01:20
3b0da9d
to
55c5f82
Compare
vitorvargasdev
force-pushed
the
feat/add-support-to-multi-channels
branch
from
April 21, 2024 01:27
55c5f82
to
1157bf7
Compare
vitorvargasdev
force-pushed
the
feat/add-support-to-multi-channels
branch
2 times, most recently
from
April 21, 2024 05:58
3c151e0
to
1655b24
Compare
vitorvargasdev
force-pushed
the
feat/add-support-to-multi-channels
branch
from
April 21, 2024 05:59
1655b24
to
bfb293a
Compare
Total Coverage: 93.22% Coverage Report
|
Total Coverage: 97.35% Coverage Report
|
carlossantos74
approved these changes
Apr 22, 2024
🎉 This PR is included in version 6.1.0-lab.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.1.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Multi-Channel Support
Previously, only supported a single channel. Now, I'm introducing multi-channel support, allowing clients to define their own channels.
Now, I've implemented multi-channel support, enabling clients to define their own channels. To achieve this, I've created a new class capable of distributing methods for
subscribe
,unsubscribe
,publish
, anddisconnect
.Before
Previously, when connecting to Realtime, we would receive one channel along with its respective handling methods.
After
Now, with the introduction of multi-channel support, we instantiate the Realtime class and then connect to whichever channels are desired. For example:
Subsequently, for each respective channel created, we receive the corresponding set of handling methods.