Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

feat: new realtime video #649

Merged
merged 4 commits into from
May 8, 2024
Merged

feat: new realtime video #649

merged 4 commits into from
May 8, 2024

Conversation

Raspincel
Copy link
Contributor

No description provided.

@carlossantos74 carlossantos74 changed the title Feat/new realtime video feat: new realtime video May 3, 2024
carlossantos74
carlossantos74 reviewed May 3, 2024
View reviewed changes
src/components/video/types.ts Show resolved Hide resolved
src/services/stores/global/index.ts Show resolved Hide resolved
src/components/video/index.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot deleted a comment from SuperViz-Dev May 7, 2024
@github-actions github-actions bot deleted a comment from SuperViz-Dev May 7, 2024
carlossantos74
carlossantos74 reviewed May 8, 2024
View reviewed changes
src/components/video/index.ts Outdated
Comment on lines 220 to 221
// const { destroy } = this.useStore(StoreType.VIDEO);
// destroy();
Copy link
Collaborator

@carlossantos74 carlossantos74 May 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to destroy the video store

src/components/video/index.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot deleted a comment from SuperViz-Dev May 8, 2024
@github-actions github-actions bot deleted a comment from SuperViz-Dev May 8, 2024
@github-actions github-actions bot deleted a comment from SuperViz-Dev May 8, 2024
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 93.51%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
   stores.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
   use-store.ts 80% 100% 100% 34
src/components
   index.ts 100% 75% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 83.33% 100% 94.12% 45, 46, 47, 48
src/components/comments
   index.ts 94.44% 93.33% 96.40% 241, 298, 357, 358, 359, 361, 479, 517, 586, 699, 715
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 54.55% 85.71% 88.09% 202, 249, 249, 249, 249, 250, 251, 254, 254, 255, 258, 328, 329, 331, 331, 331, 333, 333, 334, 336, 337, 340, 342, 391, 392, 393, 412, 423, 434, 438, 451, 472, 497, 517, 518, 529, 530, 531, 532, 533, 533, 533, 533, 533, 535, 535, 536, 536, 536, 536, 540, 542, 543
src/components/comments/html-pin-adapter
   index.ts 91.59% 96.55% 96.35% 277, 278, 279, 336, 363, 470, 471, 492, 493, 495, 495, 497, 498, 500, 500, 500, 500, 502, 503, 718, 719, 720, 797, 798, 799
src/components/form-elements
   index.ts 98.51% 100% 100% 96
   types.ts 100% 100% 100%
src/components/presence-mouse
   index.ts 50% 50% 90% 10, 11
   types.ts 100% 100% 100%
src/components/presence-mouse/canvas
   index.ts 64.71% 77.27% 87.57% 101, 102, 111, 112, 113, 114, 134, 134, 136, 160, 163, 163, 164, 165, 243, 243, 243, 243, 327, 355, 355, 357, 416, 78, 79, 80, 81, 82, 84, 85, 86, 87, 96, 97
src/components/presence-mouse/html
   index.ts 92.45% 96.97% 99.39% 281, 281, 283, 303, 565, 680
src/components/realtime
   channel.ts 73.33% 80% 85.19% 118, 118, 120, 122, 123, 126, 128, 132, 133, 154, 55, 56, 57, 83, 84, 98
   index.ts 100% 100% 96.97% 73
   types.ts 100% 100% 100%
src/components/video
   index.ts 92.19% 95.16% 95.99% 193, 194, 197, 198, 210, 211, 268, 364, 631, 656, 671, 683, 697, 699, 779, 862
src/components/who-is-online
   index.ts 98.73% 100% 98.51% 238, 567, 731, 732, 734
   types.ts 100% 100% 100%
src/core
   index.ts 80% 57.14% 76.47% 115, 118, 122, 123, 125, 130, 130, 139, 141, 147, 69, 69, 71, 72, 73, 93, 94
src/core/launcher
   index.ts 89.47% 80% 85.57% 118, 120, 121, 125, 128, 320, 334, 335, 357, 359, 360, 368, 373, 404, 405, 405, 408, 409, 411, 416, 417, 424, 426, 427, 429, 430, 431, 432, 471, 472, 473
src/services
src/services/api
   index.ts 100% 88.24% 88.33% 102, 103, 105, 111, 112, 113, 114
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/io
   index.ts 100% 83.33% 86.67% 49, 50
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 63.93% 58.54% 69.47% 150, 151, 154, 155, 170, 239, 241, 279, 280, 281, 282, 283, 283, 284, 285, 322, 323, 394, 502, 503, 504, 505, 507, 510, 511, 512, 514, 515, 517, 517, 517, 518, 519, 521, 522, 523, 527, 527, 528, 531, 540, 540, 541, 546, 547, 550, 553, 553, 554, 555, 557, 558, 559, 562, 566, 566, 568, 569, 573, 573, 573, 573, 575, 575, 575, 577, 585, 585, 587, 591, 593, 593, 594, 597, 599, 611, 612, 622, 624, 634, 636, 636, 637, 640, 76, 80, 84, 88, 92, 93, 94
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 80% 92.31% 35
src/services/roomState
   index.ts 90.32% 100% 99.17% 147, 234, 235, 74
   type.ts 100% 100% 100%
src/services/slot
   index.ts 40% 87.50% 76.92% 44, 61, 80, 80, 80, 80, 82, 82, 83, 84, 85, 88, 91, 91, 91, 91, 92, 93
src/services/stores
   index.ts 100% 100% 100%
src/services/stores/common
   utils.ts 100% 100% 100%
src/services/stores/global
   index.ts 0% 100% 96.15% 17, 18
src/services/stores/presence3D
   index.ts 0% 33.33% 78.57% 11, 12, 19, 29
src/services/stores/subject
   index.ts 100% 100% 100%
src/services/stores/video
   index.ts 0% 100% 96.97% 20, 21
src/services/stores/who-is-online
   index.ts 0% 100% 97.92% 25, 26
src/services/video-conference-manager
   index.ts 61.90% 84.21% 93.53% 121, 124, 125, 126, 170, 175, 207, 208, 213, 214, 215, 218, 218, 219, 221, 222, 300, 312, 334, 361, 362, 363, 416, 450, 561, 573, 616, 620, 679
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.35%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 75% 100% 83.52% 28, 32, 33, 34, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/base/utils
   importStyle.ts 66.67% 100% 100% 3
src/web-components/comments
   comments.ts 88.24% 76.92% 87.80% 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 137, 64, 65, 66, 79, 80, 94, 95, 96, 97, 98, 99
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 96.43% 96.73% 181, 182, 183, 184, 185, 186, 187, 188, 232, 233
   annotation-pin.ts 100% 100% 95.19% 118, 123, 124, 125, 126, 183, 184, 185, 74, 75, 76, 77, 78
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 96.55% 97.69% 233, 234, 235, 238, 239, 267, 268, 365, 366, 380, 381
   comment-item.ts 100% 90.48% 96.43% 102, 103, 104, 279, 280, 89, 90, 91, 92, 95, 96
   content.ts 96.15% 81.82% 89.15% 108, 109, 39, 40, 43, 44, 45, 51, 52, 53, 67, 78, 79, 80, 81
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 87.65% 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 50, 51, 55, 56, 72, 81
   index.ts 100% 100% 100%
   mention-list.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   mention-list.style.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   autocomplete-handler.ts 100% 100% 98.29% 25, 26
   mention-handler.ts 100% 100% 100%
   watermark.ts 100% 100% 86.15% 15, 16, 17, 18, 19, 20, 21, 22, 23
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 92.31% 100% 97.67% 156, 157, 158, 159, 160, 161, 189, 223, 260, 83, 86
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 85.19% 100% 95.15% 109, 110, 111, 112, 114, 115, 116, 117, 152, 156, 221, 222, 223, 224, 88, 90, 91, 92, 94, 95, 96
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 89.86% 100% 96.95% 249, 250, 268, 269, 270, 282, 283, 284, 296, 297, 298, 327, 328, 329, 69, 70, 75, 76
src/web-components/who-is-online/components
   dropdown.ts 97.50% 94.74% 97.86% 138, 139, 140, 141, 142, 143, 146
   index.ts 100% 100% 100%
   messages.ts 100% 80% 97.27% 126, 127, 135, 136, 144, 145
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   messages.style.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@carlossantos74 carlossantos74 merged commit 33549ef into lab May 8, 2024
4 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.1.0-lab.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.1.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossantos74 carlossantos74 carlossantos74 approved these changes

@vitorvargasdev vitorvargasdev Awaiting requested review from vitorvargasdev

Assignees
No one assigned
Labels
released on @beta released on @lab released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Raspincel @SuperViz-Dev @carlossantos74