This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total Coverage: 94.08% Coverage Report
|
Total Coverage: 97.36% Coverage Report
|
carlossantos74
approved these changes
Jun 10, 2024
🎉 This PR is included in version 6.3.0-lab.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When destroying a room with video, I noticed some errors on the console
Publishing to the stores the localParticipant as undefined was bound to throw some error, since no subscription to the global store was made with the possibility of the local participant being undefined in mind
When destroying the video, the Video Manager was being destroyed before the Video component tried to unsubscribe from the Observers in the VM, so an error was thrown